Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9997 Add integrity check for external script #10035

Merged
merged 1 commit into from
Mar 6, 2024
Merged

#9997 Add integrity check for external script #10035

merged 1 commit into from
Mar 6, 2024

Conversation

offtherailz
Copy link
Member

@offtherailz offtherailz commented Mar 6, 2024 •
edited
Loading

Description

This PR adds itnegrity check to external script tags resources.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: security enforcement

Issue

What is the current behavior?

Fix #9997

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@offtherailz offtherailz self-assigned this Mar 6, 2024
@offtherailz offtherailz requested a review from tdipisa March 6, 2024 15:11
@offtherailz offtherailz modified the milestone: 2024.01.00 Mar 6, 2024
@tdipisa tdipisa added this to the 2024.01.00 milestone Mar 6, 2024
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Mar 6, 2024
@tdipisa tdipisa merged commit 3af61c6 into geosolutions-it:master Mar 6, 2024
6 checks passed
@ElenaGallo
Copy link
Contributor

@offtherailz please backport to stable branch. Thanks

@offtherailz
Copy link
Member Author

offtherailz commented Mar 14, 2024 •
edited
Loading

I see that in production it rises an error. I think it is because of the async part that has been removed in error.
Going to send a sencond PR to fix this before to backport.
image

@offtherailz offtherailz mentioned this pull request Mar 14, 2024
Merged
12 tasks
@tdipisa
Copy link
Member

tdipisa commented Mar 15, 2024

@offtherailz other PR merged I think you can proceed with the backport of both as soon as double checked on dev deploy.

offtherailz added a commit to offtherailz/MapStore2 that referenced this pull request Mar 29, 2024
@offtherailz
geosolutions-it#9997 Add integrity check for external script (geosolu…
ee457f1 
…tions-it#10035)
@offtherailz offtherailz mentioned this pull request Mar 29, 2024
Merged
tdipisa pushed a commit that referenced this pull request Apr 2, 2024
@offtherailz
[Backport 2024.01.xx] Integrity check attribute for external JS resou…
68a1eed 
…rces (#10140)

* #9997 Add integrity check for external script (#10035)

* Fix async load for script in templates (#10073)
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Apr 3, 2024
offtherailz added a commit to offtherailz/MapStore2 that referenced this pull request Apr 10, 2024
@offtherailz
geosolutions-it#9997 Add integrity check for external script (geosolu…
5762646 
…tions-it#10035)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdipisa tdipisa tdipisa approved these changes

Assignees

@offtherailz offtherailz

Labels
C125-AUSTROCONTROL-2024-MapStore
Projects
None yet
Milestone
2024.01.00
Development

Successfully merging this pull request may close these issues.

Integrity check attribute for external JS resources
3 participants
@offtherailz @ElenaGallo @tdipisa