Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build problem #9688

Closed
cisco974 opened this issue Nov 10, 2023 · 4 comments · Fixed by #10046 or #10143
Closed

Build problem #9688

cisco974 opened this issue Nov 10, 2023 · 4 comments · Fixed by #10046 or #10143
Assignees
Milestone

Comments

@cisco974
Copy link

Description

When I try to install the MapSotre back-end on a mac

How to reproduce

After retrieving the source code from github and building the front-end (without any problems)
Run ./build.sh

Current Result
SUMMARY:
✔ 7963 tests completed
ℹ 5 tests skipped
⚠ 129 tests slow
✖ 1 test failed

FAILED TESTS:
Test the DOMUtils
✖ test getOffsetBottom
Chrome Headless 119.0.6045.123 (Mac OS 10.15.7)
Error: Expected 11 to equal 10
at assert (webpack://mapstore2/./node_modules/expect/lib/assert.js?:29:9)
at Expectation.toEqual (webpack://mapstore2/./node_modules/expect/lib/Expectation.js?:85:30)
at Context.eval (webpack://mapstore2/./web/client/utils/tests/DOMUtil-test.js?:44:59)

Other useful information

Java version : openjdk version "11.0.21"
node : v16.19.1
npm : 8.19.3
Apache Maven 3.9.5

@cisco974 cisco974 added the bug label Nov 10, 2023
@tdipisa
Copy link
Member

tdipisa commented Nov 10, 2023

@cisco974 thank you so much for reporting this. Can I kindly ask you to ask in ML for this problem? Doing that, one of our team member will be able to double check and the issue will be re-opened if needed.

@tdipisa tdipisa closed this as completed Nov 10, 2023
@cisco974
Copy link
Author

What does ML mean?

@tdipisa
Copy link
Member

tdipisa commented Nov 10, 2023

Mailing List. Here in the readme are reported the links so that you can subscribe if you want. Thank you so much.

@fkellner
Copy link
Contributor

fkellner commented Mar 7, 2024

I can reproduce that bug on my Mac. Opening the tested HTML in the browser, it becomes clear why: The clientHeight that is being computed is 18.5px, which seems to be rounded up.

image

Because the height of the tested DOM node is not set explicitly, this test is bound to be flaky. I would suggest adding an explicit height to the content, like such:

image

One might also want to explicitly set the body margin to prevent further flakyness, maybe like

document.body.style.cssText = 'margin: 8px;';
document.body.innerHTML = `
<div id="container">
    <div id="content" style="height: 18px">
    test
    </div>
</div>`;

fkellner pushed a commit to fkellner/MapStore2 that referenced this issue Mar 7, 2024
@tdipisa tdipisa reopened this Mar 7, 2024
@tdipisa tdipisa added this to the 2024.01.01 milestone Mar 7, 2024
MV88 pushed a commit that referenced this issue Mar 29, 2024
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Apr 2, 2024
@MV88 MV88 modified the milestones: 2024.01.01, 2024.01.00 Apr 2, 2024
MV88 pushed a commit to MV88/MapStore2 that referenced this issue Apr 2, 2024
…varying browser default stylesheet (geosolutions-it#10046)

Co-authored-by: Florian Kellner <[email protected]>
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Apr 2, 2024
tdipisa pushed a commit that referenced this issue Apr 2, 2024
… default stylesheet (#10046) (#10143)

Co-authored-by: fkellner <[email protected]>
Co-authored-by: Florian Kellner <[email protected]>
@ElenaGallo ElenaGallo self-assigned this Apr 3, 2024
offtherailz pushed a commit to offtherailz/MapStore2 that referenced this issue Apr 10, 2024
…varying browser default stylesheet (geosolutions-it#10046)

Co-authored-by: Florian Kellner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment