Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catalog Tool update to support 3D tiles resources in CSW metadata #9368

Closed
1 of 8 tasks
tdipisa opened this issue Aug 30, 2023 · 10 comments · Fixed by #9443, #9465 or #9599
Closed
1 of 8 tasks

Catalog Tool update to support 3D tiles resources in CSW metadata #9368

tdipisa opened this issue Aug 30, 2023 · 10 comments · Fixed by #9443, #9465 or #9599
Assignees
@ElenaGallo @mahmoudadel54
Labels
3D All issues related to the 3D rendering in CesiumJs Accepted C027-COMUNE_FI-2023-SUPPORT enhancement Good first issue
Milestone
2023.02.01

Comments

@tdipisa
Copy link
Member

tdipisa commented Aug 30, 2023 •
edited
Loading

Thanks to https://github.com/geosolutions-it/MapStore2-C027/issues/155 it is now possible to configure 3D Tiles metadata on the GeoNetwork side.
Within this issue it is requested to update the Catalog tool of MapStore (the CSW parsing part) in order to be able to recognize this data type and manage it client side.

Acceptance criteria

  • MS is loading DC metadata from CSW, therefore it should be possible to distinguish 3D Tiles online resources from the other and catch them for their purposes
  • MS receives the URL of the 3D Tile in the metadata to be able to add it to the map. By properly configuring the metadata template editor in advanced settings of the CSW source, it should also be possible then to show the direct link to the 3D Tile online resource when expanding the item in the catalog result list (eg. using the ${uri} placeholder to show automatically all clickable links of online resources available in the metadata). Clicking on that link a new browser tab should open to bring user to the tileset.json of the 3D Tile.

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information

Sample metadata and sample CSW catalog to be used for this issue are reported here. VPN connection needed.
@tdipisa tdipisa added this to the 2024.01.00 milestone Aug 30, 2023
@tdipisa tdipisa self-assigned this Aug 30, 2023
@tdipisa tdipisa modified the milestones: 2024.01.00, 2023.02.00 Aug 31, 2023
@tdipisa tdipisa assigned mahmoudadel54 and unassigned tdipisa Sep 4, 2023
@tdipisa
Copy link
Member Author

tdipisa commented Sep 7, 2023

moving temporarily in blocked to migrate the sample metadata to a public CSW

@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 11, 2023
@tdipisa tdipisa modified the milestones: 2023.02.00, 2023.02.01 Sep 11, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 14, 2023
@mahmoudadel54
geosolutions-it#9368: adding support 3D tiles resources in catalog fo…
66e7fce 
…r CSW
@mahmoudadel54 mahmoudadel54 mentioned this issue Sep 14, 2023
Merged
4 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Sep 14, 2023 that will close this issue
#9368: adding support 3D tiles resources in catalog for CSW #9443
Merged
4 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 14, 2023
@mahmoudadel54
geosolutions-it#9368: enable reading metadata from csw for 3d tiles
59ed175
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 17, 2023
@mahmoudadel54
geosolutions-it#9368: resolve comment of removing unneeded code in lo…
a735287 
…calConfig
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 18, 2023
@mahmoudadel54
geosolutions-it#9368: resovle comment: provide more generic test data…
ce92a29 
… for testing 3d tiles in csw in test file
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 18, 2023
@mahmoudadel54
geosolutions-it#9368: resolve comment about renaming 'getCesiumBoundF…
7f3d5b7 
…romOWS' function to 'transformExtentToObj' and add decription to test file for coordinateUtils
MV88 pushed a commit that referenced this issue Sep 18, 2023
@mahmoudadel54
#9368: adding support 3D tiles resources in catalog for CSW (#9443)
936c030 
* #9368: adding support 3D tiles resources in catalog for CSW
* #9368: enable reading metadata from csw for 3d tiles
* #9368: resolve comment of removing unneeded code in localConfig
* #9368: resovle comment: provide more generic test data for testing 3d tiles in csw in test file
* #9368: resolve comment about renaming 'getCesiumBoundFromOWS' function to 'transformExtentToObj' and add decription to test file for coordinateUtils
* resolving review changes
Desription:
* resolving review comments
Description: \n 1- Edit in function description in CoordinatesUtils. \n 2- Remove not needed cfg in localConfig
* resolve review comments
Description: \n - edit IT translation. \n - edit transformExtentToObj description/
@mahmoudadel54 mahmoudadel54 mentioned this issue Sep 19, 2023
Closed
4 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Sep 19, 2023 that will close this issue
#9368: adding support 3D tiles resources in catalog for CSW #9462
Closed
4 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 19, 2023
@mahmoudadel54
geosolutions-it#9368: resolve test report comments
4063d8e 
description: remove not needed span indicator for 3d layer in catalog sidebar+ remove all relevant translates
@mahmoudadel54 mahmoudadel54 mentioned this issue Sep 19, 2023
Merged
4 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Sep 19, 2023 that will close this issue
#9368: adding support 3D tiles resources in catalog for CSW #9465
Merged
4 tasks
MV88 pushed a commit that referenced this issue Sep 20, 2023
@mahmoudadel54
#9368: resolve test report comments (#9465)
5a31d50 
description: remove not needed span indicator for 3d layer in catalog sidebar+ remove all relevant translates
@tdipisa
Copy link
Member Author

tdipisa commented Sep 22, 2023 •
edited
Loading

@ElenaGallo this is our GN instance you can use for functional tests: http://gn3-rndt.geo-solutions.it/geonetwork. Test metadata is https://gn3-rndt.geo-solutions.it/geonetwork/srv/eng/catalog.search#/metadata/test:20230829_test_3dtile_01

@tdipisa
Copy link
Member Author

tdipisa commented Oct 9, 2023 •
edited
Loading

@etj when we try to connect to our GN instance with the MS Catalog tool, we always obtain the following response:

image

that seems application related. How can we solve this?

@etj
Copy link
Member

etj commented Oct 11, 2023

I just set the record as public.

This call is working without any problem
https://gn3-rndt.geo-solutions.it/geonetwork/srv/eng/csw?service=CSW&version=2.0.2&request=GetRecordById&id=test:20230829_test_3dtile_01&outputschema=http://www.isotc211.org/2005/gmd&elementsetname=full&typenames=csw:Record&resultType=results

@tdipisa
Copy link
Member Author

tdipisa commented Oct 11, 2023 •
edited
Loading

@etj it is working now, thank you. @ElenaGallo you can start testing in DEV. I see there is only an issue with the zoom to layer for which an improvement is necessary (new issue @ElenaGallo same milestone).

@ElenaGallo
Copy link
Contributor

@tdipisa zoom to layer seems to work for me but I don't see the layer on the map (no error on console).

This is the test map

3D.tile.on.csw.mp4

@ElenaGallo ElenaGallo self-assigned this Oct 12, 2023
@tdipisa
Copy link
Member Author

tdipisa commented Oct 12, 2023

@tdipisa zoom to layer seems to work for me but I don't see the layer on the map (no error on console).

That's the problem when I say

I see there is only an issue with the zoom to layer for which an improvement is necessary (new issue @ElenaGallo same milestone).

The zoom area is not correct. Please open the issue.

@ElenaGallo ElenaGallo mentioned this issue Oct 12, 2023
Closed
1 task
@ElenaGallo
Copy link
Contributor

@tdipisa new issue here: ##9585

@tdipisa
Copy link
Member Author

tdipisa commented Oct 12, 2023

@ElenaGallo can we backport this in the meantime then?

@ElenaGallo
Copy link
Contributor

@tdipisa yes, @mahmoudadel54 please backport #9465 and #9443

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 15, 2023
@mahmoudadel54
geosolutions-it#9368: adding support 3D tiles resources in catalog fo…
bb895c1 
…r CSW (geosolutions-it#9443)

* geosolutions-it#9368: adding support 3D tiles resources in catalog for CSW
* geosolutions-it#9368: enable reading metadata from csw for 3d tiles
* geosolutions-it#9368: resolve comment of removing unneeded code in localConfig
* geosolutions-it#9368: resovle comment: provide more generic test data for testing 3d tiles in csw in test file
* geosolutions-it#9368: resolve comment about renaming 'getCesiumBoundFromOWS' function to 'transformExtentToObj' and add decription to test file for coordinateUtils
* resolving review changes
Desription:
* resolving review comments
Description: \n 1- Edit in function description in CoordinatesUtils. \n 2- Remove not needed cfg in localConfig
* resolve review comments
Description: \n - edit IT translation. \n - edit transformExtentToObj description/
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 15, 2023
@mahmoudadel54
geosolutions-it#9368: resolve test report comments (geosolutions-it#9465
3be219e 
)

description: remove not needed span indicator for 3d layer in catalog sidebar+ remove all relevant translates
@mahmoudadel54 mahmoudadel54 mentioned this issue Oct 15, 2023
Merged
4 tasks
@tdipisa tdipisa linked a pull request Oct 16, 2023 that will close this issue
[Backport 2023.02.xx] #9368: adding support 3D tiles resources in catalog for CSW #9599
Merged
4 tasks
tdipisa pushed a commit that referenced this issue Oct 16, 2023
@mahmoudadel54
[Backport 2023.02.xx] #9368: adding support 3D tiles resources in cat…
32eb916 
…alog for CSW (#9599)

* #9368: adding support 3D tiles resources in catalog for CSW (#9443)

* #9368: adding support 3D tiles resources in catalog for CSW
* #9368: enable reading metadata from csw for 3d tiles
* #9368: resolve comment of removing unneeded code in localConfig
* #9368: resovle comment: provide more generic test data for testing 3d tiles in csw in test file
* #9368: resolve comment about renaming 'getCesiumBoundFromOWS' function to 'transformExtentToObj' and add decription to test file for coordinateUtils
* resolving review changes
Desription:
* resolving review comments
Description: \n 1- Edit in function description in CoordinatesUtils. \n 2- Remove not needed cfg in localConfig
* resolve review comments
Description: \n - edit IT translation. \n - edit transformExtentToObj description/

* #9368: resolve test report comments (#9465)

description: remove not needed span indicator for 3d layer in catalog sidebar+ remove all relevant translates
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 16, 2023
@tdipisa tdipisa added the 3D All issues related to the 3D rendering in CesiumJs label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
3D All issues related to the 3D rendering in CesiumJs Accepted C027-COMUNE_FI-2023-SUPPORT enhancement Good first issue
Projects
None yet
Milestone
2023.02.01
4 participants
@etj @tdipisa @ElenaGallo @mahmoudadel54