Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for isNull logical operator on date field in layer filter #9325

Closed
1 of 6 tasks
tdipisa opened this issue Aug 3, 2023 · 3 comments · Fixed by #9423 or #9573
Closed
1 of 6 tasks

Support for isNull logical operator on date field in layer filter #9325

tdipisa opened this issue Aug 3, 2023 · 3 comments · Fixed by #9423 or #9573

Comments

@tdipisa
Copy link
Member

tdipisa commented Aug 3, 2023

Description

To provide the support for isNull as a new operator on date field in Attribute Filter for LayerFilter tool.

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information

@tdipisa tdipisa added this to the 2023.02.00 milestone Aug 3, 2023
@dsuren1 dsuren1 changed the title Support for isNull logical operator in layer filter Support for isNull logical operator on date field in layer filter Aug 3, 2023
@dsuren1
Copy link
Contributor

dsuren1 commented Aug 3, 2023

Investigation

Date field by default uses defaultOperator configured.

  • So for this custom operator support, add a type for date, something like this to include isNull.
 case "date": {
     return [...this.props.defaultOperators, "isNull"];
 }
  • Filter conversion on payload is already available for this operator. So no extra step required for this.
  • The field value should be disabled when isNull operator is selected. This should be done on DateField component

@itsajay1029
Copy link

I want to work for this. Can you assign it to me @tdipisa ?

@tdipisa
Copy link
Member Author

tdipisa commented Aug 4, 2023

Dear @itsajay1029 I'm happy to have you involved to contribute for this if you wish. If you think you can contribute relatively soon to this we can consider to have the enhancement for the next major release 2023.02.00. Just let me know.

@tdipisa tdipisa added the new label Aug 4, 2023
@tdipisa tdipisa added this to the 2023.02.01 milestone Aug 31, 2023
@tdipisa tdipisa assigned mahmoudadel54 and unassigned tdipisa Sep 4, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 11, 2023
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 11, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 12, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 12, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 12, 2023
allyoucanmap pushed a commit that referenced this issue Sep 12, 2023
@ElenaGallo ElenaGallo self-assigned this Sep 12, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 9, 2023
tdipisa pushed a commit that referenced this issue Oct 9, 2023
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment