Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure hidden columns in featuregrid #9219

Closed
2 tasks done
dsuren1 opened this issue Jun 13, 2023 · 8 comments · Fixed by #9226, #9236 or #9262
Closed
2 tasks done

Allow to configure hidden columns in featuregrid #9219

dsuren1 opened this issue Jun 13, 2023 · 8 comments · Fixed by #9226, #9236 or #9262

Comments

@dsuren1
Copy link
Contributor

dsuren1 commented Jun 13, 2023

Description

Allow user configuration of the feature grid columns to be saved on map save and also in usersession when user session plugin is enabled. It should be applicable for both map and context

Ref: georchestra/mapstore2-georchestra#378

Acceptance criteria

Save attribute table column state

  • On map save
  • In user session
@dsuren1 dsuren1 added this to the 2023.01.02 milestone Jun 13, 2023
@dsuren1 dsuren1 self-assigned this Jun 13, 2023
@tdipisa tdipisa modified the milestones: 2023.01.02, 2023.02.00 Jun 15, 2023
dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Jun 15, 2023
@dsuren1 dsuren1 linked a pull request Jun 15, 2023 that will close this issue
5 tasks
@offtherailz
Copy link
Member

offtherailz commented Jun 16, 2023

Hi, my understanding is that here we are saving only the attributes selected for the current layer (last) of the feature grid.
I think these settings should be saved ideally layer by layer. So we should have a by-id reference.

please @tdipisa and @dsuren1 clarify this to me so I can proceed with the review.

Moreover take into account to use the new registerCustomSaveHandler actually used for MapViews and in some extensions, to add data to the map configuration.
This new solution is more modular and should allow to separate more the plugins from the general save logic. Anyway I'm not sure if session tool can handle this.

@tdipisa
Copy link
Member

tdipisa commented Jun 16, 2023

@offtherailz we have to make persistent in map state when saving the map and in user session the status of visible attributes in Attribute table. Therefore yes, it should be managed for each layer in theory, I think. That's should be the logic, why are you asking? Can it be also different maybe?

@dsuren1
Copy link
Contributor Author

dsuren1 commented Jun 16, 2023

@offtherailz

So we should have a by-id reference.

I believe now it saves all attributes reference by map for all layers in it.

@offtherailz
Copy link
Member

I can confirm you are right. My apologies for the noise

@tdipisa
Copy link
Member

tdipisa commented Jun 16, 2023

I'm sorry @offtherailz who is right and for what? :-)

@offtherailz
Copy link
Member

@dsuren1 is right, the feature grid saves layer by layer the options.
I probably did an error during the preliminary check.

@tdipisa
Copy link
Member

tdipisa commented Jun 16, 2023

Ok @offtherailz. Thank you.

@ElenaGallo ElenaGallo self-assigned this Jun 16, 2023
@tdipisa
Copy link
Member

tdipisa commented Jun 16, 2023

@offtherailz @ElenaGallo @dsuren1
I don't know what has been tested so far but it seems the requested support for User Session involving this new enhancement is not working as expected:

session_1

The support for map save seems working as expected instead.
Moving back to ready for further checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment