Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new widgets on the map are under the TOC #8726

Closed
ElenaGallo opened this issue Oct 24, 2022 · 5 comments
Closed

The new widgets on the map are under the TOC #8726

ElenaGallo opened this issue Oct 24, 2022 · 5 comments

Comments

@ElenaGallo
Copy link
Contributor

If I add a new widget to a map, it will located below the TOC instead of being placed on the right side of the map viewer

Current Result
https://images.zenhubusercontent.com/39382076/b9f31027-af3c-493f-97aa-9433229b86cd/addno.mov

Expected Result
https://images.zenhubusercontent.com/39382076/c91a86f6-75e5-4c0b-90d3-b6adddbb6e4d/addyes.mov

@tdipisa
Copy link
Member

tdipisa commented Oct 24, 2022

@belom88 please as part of the preliminary investigation we need to understand what introduced this regression.

@belom88
Copy link
Contributor

belom88 commented Oct 25, 2022

Breaking commit: 70322da
Breaking change:

left: leftOffset + 'px',

@tdipisa
Copy link
Member

tdipisa commented Oct 25, 2022

Thank you @belom88. I've added the project label accordingly. Please have a quick sync with @alex-fko if needed so that then you can provide the needed fix. @allyoucanmap, you have reviewed #8621, any concern for this?

belom88 added a commit to belom88/MapStore2 that referenced this issue Oct 25, 2022
@tdipisa
Copy link
Member

tdipisa commented Oct 28, 2022

@alex-fko can you please keep track of your feedback for this here with a comment. Let's wait then the feedback of @allyoucanmap who reviewed the PRs. Then, we will manage this accordingly.

@alex-fko
Copy link
Contributor

Comment with initial suggestion for the issue: #8622 (comment)

Adding offset deducts space utilized by the grid, while breakpoints are triggered by grid width.
If offset from the left side will always be active, regardless of hidden/visible TOC, then all devices having viewport width < 1100px will have single-column layout because of breakpoint hit.
To prevent layout switch 4-1-4 columns we need to think of a way of applying this offset from the left only if viewport can actually fit expanded TOC + widgets grid with 500px and more width and maybe force 1-column layout otherwise (viewport width < 1100px).

@allyoucanmap allyoucanmap assigned allyoucanmap and unassigned belom88 Oct 31, 2022
dsuren1 pushed a commit that referenced this issue Oct 31, 2022
* improve widgets layout on map

* restore map layout selector
@ElenaGallo ElenaGallo self-assigned this Oct 31, 2022
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this issue Nov 3, 2022
…osolutions-it#8751)

* improve widgets layout on map

* restore map layout selector
dsuren1 pushed a commit that referenced this issue Nov 3, 2022
* improve widgets layout on map

* restore map layout selector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment