Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style packages dependencies #6946

Closed
1 task done
allyoucanmap opened this issue Jun 4, 2021 · 8 comments
Closed
1 task done

Update style packages dependencies #6946

allyoucanmap opened this issue Jun 4, 2021 · 8 comments

Comments

@allyoucanmap
Copy link
Contributor

Description

It would be nice to update following libraries:

  • update bootstrap to 3.3.7 the latest supported version of react-bootstrap. This update will help the geonode-mapstore integration
  • and less language to 4.1.1 to support map functionalities. This will help in the creation of for loop for theme variants

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features

Other useful information

@ElenaGallo
Copy link
Contributor

@allyoucanmap there are some style problem:

  • The toc toolbar and the search layers bar are moved up
    1

  • The color of the family font on visual editor is lighter
    2

  • The close button in the save changes pop up and the delete button in delete pop up are moved up
    3
    4

@allyoucanmap
Copy link
Contributor Author

@ElenaGallo thanks, I'll work on it

@dsuren1
Copy link
Contributor

dsuren1 commented Jun 8, 2021

@allyoucanmap Looks like degrading less lib to 3.13.1 seems to work

@allyoucanmap
Copy link
Contributor Author

@dsuren1 I would prefer to keep latest version of less, the issue is due to computation of variables not included in parentheses, working on it

@dsuren1
Copy link
Contributor

dsuren1 commented Jun 8, 2021

@allyoucanmap Yes that's right, seems like it's also affecting some styles (scss) conversion from other libraries as well. I just came across one.
Ex. NumberPicker from react-widgets
2021-06-08 20_22_44-MapStore HomePage
We can just override those classes, however, not sure how many such similar libs have impacted.

@allyoucanmap
Copy link
Contributor Author

@dsuren1 just checked and it seems react-widget is not included in the main theme but included directly in the components. The library has an issue with the computation of the buttons. Just tried to add it to the main theme with the overrides and it solve the issue:

@import 'react-widgets/lib/less/react-widgets.less';
.rw-numberpicker {
    .rw-btn {
        height: (@input-height / 2);
        line-height: (@input-height / 2);
    }
}

image

I would like to use a version of less greater or equal than v3.5.0 to be able to use map functionalities for theming pourpose so I would prefer to fix the style
https://lesscss.org/features/#maps-feature

@offtherailz
Copy link
Member

Save modal for maps stories etc... have some misalignments

dev:
image

Original:
image

@allyoucanmap
Copy link
Contributor Author

@offtherailz thanks, solved

@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants