Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coveralls and coverage plugin test different things #56

Closed
offtherailz opened this issue Aug 14, 2015 · 4 comments
Closed

Coveralls and coverage plugin test different things #56

offtherailz opened this issue Aug 14, 2015 · 4 comments

Comments

@offtherailz
Copy link
Member

Is impossible to test locally the coverage as coveralls does because the local tool is not aligned with the coveralls rules.
We should find a solutions to speed up the development and don't force developers to try to guess what Coveralls wants.

@mircobe87
Copy link
Contributor

In Coveralls report, lines seem to be shifted.
The karma-coverage html report seems to show the right lines coverage.

The local reporter lcovonly which is used by karma-coverage seems to report the same coveralls results.
For Atom editor we can use the lcov-info plugin to show lcovonly report.

@mbarto mbarto added this to the 0.2 milestone Sep 9, 2015
@simboss simboss modified the milestone: 0.2 Dec 23, 2015
@simboss simboss removed the ready label Oct 17, 2016
@offtherailz
Copy link
Member Author

We noticed 2 lines shift:
Can this be useful ?
https://www.npmjs.com/package/karma-remap-coverage

@offtherailz
Copy link
Member Author

Also this may help
codymikol/karma-webpack#21 (comment)

@offtherailz
Copy link
Member Author

offtherailz commented Nov 24, 2016

Did some experiment, but did not get the solution.
Tried all the libs named with a permutation of [babel, loader, webpack, coverage] but with the same result.
The problem is that the coverage info are applied on the transpiled code by babel-loader in webpack.

Someone uses isparta, that is not a mantained project. I don't thing is a good solution.
Someone else use istanbul.1.0.0-aplha.1. We could try it, but it is an alpha.

@Gnafu Gnafu closed this as completed in 5adc387 Jan 31, 2017
Gnafu added a commit that referenced this issue Jan 31, 2017
Instrument code before babel. Fixes #56
@ghost ghost assigned Gnafu Jan 31, 2017
@ghost ghost removed the In Test label Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants