Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme Switcher doesn't work #2541

Closed
1 of 4 tasks
allyoucanmap opened this issue Jan 19, 2018 · 0 comments · Fixed by #2548
Closed
1 of 4 tasks

Theme Switcher doesn't work #2541

allyoucanmap opened this issue Jan 19, 2018 · 0 comments · Fixed by #2548
Assignees
@allyoucanmap @chiaracurcio
Labels
Accepted bug Priority: Blocker
Milestone
2018.01.00 Hardening

Comments

@allyoucanmap
Copy link
Contributor

allyoucanmap commented Jan 19, 2018 •
edited
Loading

Description

Theme doesn't change

In case of Bug (otherwise remove this paragraph)

Browser Affected
(use this site: https://www.whatsmybrowser.org/ for non expert users)

  • Internet Explorer
  • Chrome
  • Firefox
  • Safari

Browser Version Affected

  • Chrome v63

Steps to reproduce

  • Go to homepage
  • Try to switch theme

Verify also:

  • Init 'Loading MapStore' message should be visible until the style has been loaded on index and embedded
  • When style are switched the version should be apply to the new theme

Expected Result

  • Theme changes

Current Result

  • Theme doesn't change

Other useful information (optional):
@allyoucanmap allyoucanmap self-assigned this Jan 22, 2018
@allyoucanmap allyoucanmap added this to the 2018.01.00 Hardening milestone Jan 22, 2018
@tdipisa tdipisa added the bug label Jan 22, 2018
@allyoucanmap allyoucanmap mentioned this issue Jan 23, 2018
Merged
5 tasks
offtherailz pushed a commit that referenced this issue Jan 23, 2018
@allyoucanmap @offtherailz
Fixes #2541 Theme Switcher fixed (#2548)
3eff8fe
@ghost ghost added Accepted and removed in progress labels Jan 23, 2018
@chiaracurcio chiaracurcio reopened this Jan 23, 2018
offtherailz pushed a commit that referenced this issue Jan 23, 2018
@allyoucanmap @offtherailz
Fixes #2541 Theme Switcher fixed (#2548)
765c1ce
@chiaracurcio chiaracurcio self-assigned this Jan 23, 2018
@snyk-bot snyk-bot mentioned this issue Sep 24, 2020
Open
@snyk-bot snyk-bot mentioned this issue Jan 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allyoucanmap allyoucanmap

@chiaracurcio chiaracurcio

Labels
Accepted bug Priority: Blocker
Projects
None yet
Milestone
2018.01.00 Hardening
Development

Successfully merging a pull request may close this issue.

Fixes #2541 Theme Switcher doesn't work allyoucanmap/MapStore2
3 participants
@tdipisa @allyoucanmap @chiaracurcio