Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Tile Grids settings for WMS service are not retained when adding a Background layer from Catalog #10487

Closed
1 task done
ale-cristofori opened this issue Jul 22, 2024 · 1 comment · Fixed by #10490
Closed
1 task done

Custom Tile Grids settings for WMS service are not retained when adding a Background layer from Catalog #10487

ale-cristofori opened this issue Jul 22, 2024 · 1 comment · Fixed by #10490
Assignees
@ElenaGallo @mahmoudadel54
Labels
Accepted bug C047-CLEVELAND-METROPARKS-2022-SUPPORT
Milestone
2024.02.00

Comments

@ale-cristofori
Copy link
Contributor

ale-cristofori commented Jul 22, 2024 •
edited by tdipisa
Loading

Description

We have the Custom Tile gridset to be enforced on every layer added from the catalog from a WMS service, acting on the Use remote custom tile grids checkbox. Whenever we add a layer from the catalog the TOC or sidebar the setting is kept for every layer coming from the WMS service set to use the custom gridsets.

The setting is not retained when adding a layer from the background selector component.

How to reproduce

Open this maps

  • On the Background layer selector click on the plus button to add a new layer.
  • Select a the CLEV METRO BG layer WMS service layer from the catalog services list.
  • Adding the layer to the map will open a dialog window
  • Notice how the custom gridsets settings are not the default for the layer to be added.

Expected Result
The layer to be added as BG layer should have the custom gridset option preset by default when opening the dialog window. Adding the layer to the map would already trigger the custom tiles settings for the BG layer

Current Result
The custom gridsets settings are not the default for the layer to be added.

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

recording_1.mp4
@tdipisa tdipisa added this to the 2024.02.00 milestone Jul 23, 2024
@tdipisa tdipisa assigned mahmoudadel54 and unassigned tdipisa Jul 23, 2024
@tdipisa
Copy link
Member

tdipisa commented Jul 23, 2024

@mahmoudadel54 the request should be similar to the one you have worked for #10281

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jul 24, 2024
@mahmoudadel54
geosolutions-it#10487: Custom Tile Grids settings for WMS service are…
99158eb 
… not retained when adding a Background layer from Catalog

Description:
- handle showing custom tile grid settings for wms service in adding background layer.
- add unit test for the changes
@mahmoudadel54 mahmoudadel54 mentioned this issue Jul 24, 2024
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jul 24, 2024
@mahmoudadel54
geosolutions-it#10487: Custom Tile Grids settings for WMS service are…
d4a47a0 
… not retained when adding a Background layer from Catalog

Description:
- fix lint issues in WMSCacheOptions file
@mahmoudadel54 mahmoudadel54 linked a pull request Jul 24, 2024 that will close this issue
#10487: Custom Tile Grids settings for WMS service are not retained when adding a Background layer from Catalog #10490
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jul 25, 2024
@mahmoudadel54
geosolutions-it#10487: Custom Tile Grids settings for WMS service are…
a1dcd22 
… not retained when adding a Background layer from Catalog

Description:
- resolve FE failing test
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jul 31, 2024
@mahmoudadel54
geosolutions-it#10487: Custom Tile Grids settings for WMS service are…
5df6e20 
… not retained when adding a Background layer from Catalog [resolve review]

- revert the prev changes
- handle the requirements in addBackgroundPropertiesEpic
- create a new wms util 'getCustomTileGridProperties'
- add unit tests
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jul 31, 2024
@mahmoudadel54
geosolutions-it#10487: Custom Tile Grids settings for WMS service are…
39aa180 
… not retained when adding a Background layer from Catalog [resolve review]

- revert the changes in BackgroundDialog file + its test file
allyoucanmap pushed a commit that referenced this issue Aug 2, 2024
@mahmoudadel54
#10487: Custom Tile Grids settings for WMS service are not retained w…
574bafc 
…hen adding a Background layer from Catalog (#10490)
@ElenaGallo ElenaGallo self-assigned this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
Accepted bug C047-CLEVELAND-METROPARKS-2022-SUPPORT
Projects
None yet
Milestone
2024.02.00
4 participants
@tdipisa @ale-cristofori @ElenaGallo @mahmoudadel54