-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Details loads panel even if the details attribute value is NODATA #10318
Closed
1 task done
Comments
MV88
added
bug
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
Regression
labels
May 14, 2024
MV88
added a commit
to MV88/MapStore2
that referenced
this issue
May 14, 2024
12 tasks
allyoucanmap
pushed a commit
that referenced
this issue
May 14, 2024
MV88
added a commit
to MV88/MapStore2
that referenced
this issue
May 14, 2024
MV88
added a commit
to MV88/MapStore2
that referenced
this issue
May 14, 2024
tdipisa
pushed a commit
that referenced
this issue
May 14, 2024
MV88
added a commit
to MV88/MapStore2
that referenced
this issue
May 14, 2024
tdipisa
removed
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
May 15, 2024
tdipisa
pushed a commit
that referenced
this issue
May 15, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
the reason this issue occurs is because the action OPEN_DETAILS_PANEL is triggered here because
it finds among map attributes the showAtStartup to true but the details are empty --> NODATA
we should prevent to the action to be dispatched if NODATA else we have also to check the value from showAtStartup flag to be true, so we have to extend condition
How to reproduce
open a map that has details set with nodata and showAtStartup to true (use this map)
Expected Result
to not load the panel
Current Result
loads the panel
Browser info
(use this site: https://www.whatsmybrowser.org/ for non expert users)Other useful information
The text was updated successfully, but these errors were encountered: