Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details loads panel even if the details attribute value is NODATA #10318

Closed
1 task done
MV88 opened this issue May 14, 2024 · 0 comments · Fixed by #10319, #10320 or #10323
Closed
1 task done

Details loads panel even if the details attribute value is NODATA #10318

MV88 opened this issue May 14, 2024 · 0 comments · Fixed by #10319, #10320 or #10323

Comments

@MV88
Copy link
Contributor

MV88 commented May 14, 2024

Description

the reason this issue occurs is because the action OPEN_DETAILS_PANEL is triggered here because
it finds among map attributes the showAtStartup to true but the details are empty --> NODATA

{
    "AttributeList": {
        "Attribute": [
            {
                "name": "owner",
                "type": "STRING",
                "value": "admin"
            },
            {
                "name": "detailsSettings",
                "type": "STRING",
                "value": "{\"showAsModal\":false,\"showAtStartup\":true}"
            },
            {
                "name": "details",
                "type": "STRING",
                "value": "NODATA"
            },
            {
                "name": "thumbnail",
                "type": "STRING",
                "value": "rest/geostore/data/1000024888/raw?decode=datauri&v=e1b32f50-b8ed-11ed-9b87-81c79c8f4695"
            }
        ]
    }
}

we should prevent to the action to be dispatched if NODATA else we have also to check the value from showAtStartup flag to be true, so we have to extend condition

How to reproduce

open a map that has details set with nodata and showAtStartup to true (use this map)

Expected Result

to not load the panel
Current Result

loads the panel

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

@MV88 MV88 added bug BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch Regression labels May 14, 2024
@MV88 MV88 added this to the 2024.01.01 milestone May 14, 2024
@MV88 MV88 self-assigned this May 14, 2024
MV88 added a commit to MV88/MapStore2 that referenced this issue May 14, 2024
@ElenaGallo ElenaGallo self-assigned this May 14, 2024
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment