Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance GeoFence attribute rule #10111

Closed
1 task done
dsuren1 opened this issue Mar 22, 2024 · 1 comment · Fixed by #10145 or #10324
Closed
1 task done

Enhance GeoFence attribute rule #10111

dsuren1 opened this issue Mar 22, 2024 · 1 comment · Fixed by #10145 or #10324

Comments

@dsuren1
Copy link
Contributor

dsuren1 commented Mar 22, 2024

Description

We have to provide a small but really useful improvement for the GeoFence Rule Manager in MS.
At the moment, when a rule is created, the tab for the attributes has the DDs set to READ ONLY by default but only the constraints on the attributes for which the user has manually changed the status of the DD are sent: the others ones are not sent to GeoFence when the rule is saved in the UI.
This often generates misunderstandings as the user thinks that the other constraints on the attributes besides the modified ones are set but instead they are not and GeoFence consequently denies write access to certain attributes configured by the user if also grant for other attribute are not specified.

Acceptance criteria

  • The attributes access type/constraints DD values should show only the following list of options NONE, READONLY, READWRITE.
  • When the attributes is enabled, upon saving the rule, the attributes along with constraints are sent in the payload
    • This is applicable regardless of whether the user makes a change to a particular attribute
    • All the attributes with currently selected constraints/access types in the UI are sent in the payload to be persisted (save/update)
  • The attributes and respective constraints/access type should always match the value persisted in the backend
  • Default access type is READONLY

What kind of improvement you want to add? (check one with "x", remove the others)

  • Enhancement

Other useful information

Ref: https://github.com/geosolutions-it/MapStore2-C040/issues/459

@dsuren1 dsuren1 self-assigned this Mar 22, 2024
@tdipisa tdipisa added this to the 2024.01.01 milestone Mar 27, 2024
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Mar 27, 2024
dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Apr 3, 2024
@dsuren1 dsuren1 linked a pull request Apr 3, 2024 that will close this issue
6 tasks
@tdipisa
Copy link
Member

tdipisa commented Apr 5, 2024

Waiting 2024.01.00 before backporting connected PR.

@ElenaGallo ElenaGallo self-assigned this Apr 24, 2024
dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue May 15, 2024
tdipisa pushed a commit that referenced this issue May 15, 2024
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment