Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive legend for TOC layers #10026

Open
1 of 6 tasks
mahmoudadel54 opened this issue Mar 6, 2024 · 0 comments · Fixed by #10180 or #10249
Open
1 of 6 tasks

Interactive legend for TOC layers #10026

mahmoudadel54 opened this issue Mar 6, 2024 · 0 comments · Fixed by #10180 or #10249
Assignees
@ElenaGallo @mahmoudadel54
Labels
investigation New Feature used for new functionalities
Milestone
2025.01.00

Comments

@mahmoudadel54
Copy link
Contributor

mahmoudadel54 commented Mar 6, 2024 •
edited
Loading

Description

For WMS layers in TOC it would be interesting to enhance the legend to be interactive so that it is possible for example to switch off layer features belonging to certain classes. For this purpose the legend should be retrieved in JSON format and the UI component managed accordingly.

This is an investigation issue where it is requested to details the way to go with involved limitations if any.

To consider:

  • JSON format is supported only by GS (to confirm)
  • There should be an option to activate this new legend format in MS (the default is the current one). In Catalog tool for example
  • Evaluate the possibility to uniform this functionality also for WFS/Vector layers client side.

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Improvement to legend component

Other useful information

Sample of request:
https://gs-stable.geo-solutions.it/geoserver/wms?service=WMS&request=GetLegendGraphic&format=application/json&height=50&width=100&layer=gs%3Aus_states&style=pophade&version=1.3.0&SLD_VERSION=1.1.0&LEGEND_OPTIONS=forceLabels%3Aon&LANGUAGE=en&SCALE=36978669
@mahmoudadel54 mahmoudadel54 self-assigned this Mar 6, 2024
@mahmoudadel54 mahmoudadel54 modified the milestone: 2024.01.01 Mar 6, 2024
@tdipisa tdipisa added this to the 2024.02.00 milestone Mar 6, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Mar 24, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers
124e01b 
Description:
- Adding interactive legend for wms layers
- Add checkbox for enable the interactive legend for wms into layer settings and for the catalog as well
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 2, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers
c291f32 
Description:
- implement reset legend filter in case changing styles for WMS
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 8, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers
85617f2 
Description:
- Adding interactive legend for wfs and vector layers
- Add checkbox for enable the interactive legend for wfs and vector into layer settings and for the catalog as well [just for wfs]
- write unit tests based on code changes
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 9, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers
5277175 
- Merge branch 'master' into feature_10026_backup
- edit in some unit tests
- remove implementation of vector layer temp.
@mahmoudadel54 mahmoudadel54 mentioned this issue Apr 9, 2024
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 9, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers
a29974f 
- fix FE test failure
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 10, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers
161178a 
- edit loopFilterArrayToFilterObject method in StyleEditorUtils file to handle the subgroups in geostyle filter
- write a unit test for it
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 11, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers [Vector laye…
8a1b4c3 
…r part]

- Adding interactive legend for vector layers
- Add checkbox for enable the interactive legend for wfs and vector into layer settings and for the catalog as well [just for wfs]
- handle the logic of filter by legend for vector layer in case of 2d openlayer map and 3d cesium map
- write unit tests based on code changes
@mahmoudadel54 mahmoudadel54 mentioned this issue Apr 11, 2024
Closed
12 tasks
This was linked to pull requests Apr 11, 2024
#10026: Interactive legend for TOC layers [WMS] #10180
Merged
#10026: Interactive legend for TOC layers [Vector layer part] #10188
Closed
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 15, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers
b0a2693 
- enhance epics related to interactive legend
- remove duplicated file
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 15, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers
3af0429 
- isolate WMS interactive legend code and remove WFS part
- edit some unit tests
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 15, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers
c76bd16 
- clean the code by remove all non related to wms interactive legend part
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 18, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers [Resolve rev…
d177ccf 
…iew comments]

- Refactor the filter legend and reset filter legend and create utils
- Handle multi-select legend filter
- handle adding popover info for failure getting json legend
- adding popover info show how to apply legend filter
- edit toc style
- remove unused epics and actions
- add translations
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 19, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers [Resolve rev…
6b7e7e3 
…iew comments]

- remove the code that is  not related to wms
- remove unused unit tests
- edit translations
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 19, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers [Resolve rev…
ff42bc6 
…iew comments]

- remove unnecessary spaces
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 19, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers [Resolve rev…
7b9bc99 
…iew comments]

- fix FE failure
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 19, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers [WMS]
2c0eaa0 
Update StyleList-test.jsx
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 19, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers [WMS]
65e5deb 
* revert wrong pushed code into test file
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 22, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers [Resolve rev…
4aa80c9 
…iew comments]

- remove hover/highlight effect if legend rule doesn't have filter statement in wms json legend
- write unit tests for  'updateLayerLegendFilter' and 'resetLayerLegendFilter' FilterUtils
allyoucanmap pushed a commit that referenced this issue Apr 22, 2024
@mahmoudadel54
Fix #10026: Interactive legend for TOC layers [WMS] (#10180)
b0144c0
@ElenaGallo ElenaGallo self-assigned this Apr 23, 2024
@ElenaGallo ElenaGallo mentioned this issue Apr 23, 2024
Open
2 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 23, 2024
@mahmoudadel54
geosolutions-it#10026: Interactive legend for TOC layers [WMS Support]
ee1b943 
Description:
- fix functional tests
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 23, 2024
@mahmoudadel54
geosolutions-it#10026: fix Interactive legend for TOC layers [WMS Sup…
0e66ce1 
…port]

Description:
- fix functional tests for interactive legend geosolutions-it#10026
@mahmoudadel54 mahmoudadel54 mentioned this issue Apr 23, 2024
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Apr 23, 2024 that will close this issue
#10026: fix functional tests for Interactive legend for TOC layers [WMS Support] #10249
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 23, 2024
@mahmoudadel54
geosolutions-it#10026: fix Interactive legend for TOC layers [WMS Sup…
7d85735 
…port]

Description:
- fix import mistake in TOCItemsSettings file
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 24, 2024
@mahmoudadel54
geosolutions-it#10026: fix Interactive legend for TOC layers [WMS Sup…
aa7ce53 
…port]

Description:
- resolve review comments by adding a configration prop for TOCItemsSettings 'hideInteractiveLegendOption'
- remove the replaced selector 'isMapOnlyOpenedSelector'
- edit unit test of 'Display-test' file
-
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 24, 2024
@mahmoudadel54
geosolutions-it#10026: fix Interactive legend for TOC layers [WMS Sup…
f5ea251 
…port]

Description:
- revert the change in map.js in selectors
allyoucanmap pushed a commit that referenced this issue Apr 24, 2024
@mahmoudadel54
#10026: fix functional tests for Interactive legend for TOC layers [W…
67252e2 
…MS Support] (#10249)
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Apr 24, 2024
@ElenaGallo ElenaGallo removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Apr 24, 2024
@tdipisa tdipisa reopened this Apr 29, 2024
@tdipisa tdipisa removed a link to a pull request Apr 29, 2024
#10026: Interactive legend for TOC layers [Vector layer part] #10188
Closed
12 tasks
@tdipisa tdipisa linked a pull request Apr 29, 2024 that will close this issue
#10026: Interactive legend for TOC layers [Vector layer part] #10188
Closed
12 tasks
@tdipisa tdipisa modified the milestones: 2024.02.00, 2025.01.00 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
investigation New Feature used for new functionalities
Projects
None yet
Milestone
2025.01.00
3 participants
@tdipisa @ElenaGallo @mahmoudadel54