Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing other issues encountered during testing #45

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Jan 26, 2024

Description

  • 3d
  • search by bookmark
  • geostory
  • dashboard embedded
  • permalink
  • dashboard catalog service

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@MV88 MV88 requested a review from tdipisa January 26, 2024 10:20
@MV88 MV88 self-assigned this Jan 26, 2024
Copy link
Member

@tdipisa tdipisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MV88 I'm sorry I don't see permalink enabled in this config.

configs/localConfig.json Show resolved Hide resolved
@tdipisa
Copy link
Member

tdipisa commented Jan 26, 2024

@MV88 I'm sorry I don't see permalink enabled in this config.

already added before same for geostory it seems

@MV88
Copy link
Contributor Author

MV88 commented Jan 26, 2024

@MV88 I'm sorry I don't see permalink enabled in this config.

already added before same for geostory it seems

did you check it was not added before?

@tdipisa tdipisa self-requested a review January 26, 2024 10:46
@MV88 MV88 merged commit f1841d2 into geosolutions-it:master Jan 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants