-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for running GEOS-Chem 14.5.1 in GEOS #2661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
yantosca
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can see things look good to merge. Granted that several of these modifications were made by folks at GMAO so I am assuming most of those are OK. Thanks @lizziel!
yantosca
added a commit
that referenced
this pull request
Jan 7, 2025
This merge brings updates (as of PR #2661) into the feature/integrator-specific-handling branch. This is necessary in order to avoid compilation errors w/ the new HEMCO logfile handling updates. Signed-off-by: Bob Yantosca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: Interface to External Model
Related to GEOS-Chem updates needed to interface with other models
no-diff-to-benchmark
This update will not change the results of fullchem benchmark simulations
topic: GEOS ESM
Related to running GEOS-Chem in the GEOS ESM
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR contains no-diff updates needed for GEOS to run GEOS-Chem 14.5.1. Changes include:
HCO_WARNING
in GEOS-Chemsulfate_mod.F90
withGC_WARNING
and enclose in if amIRoot to limit printsHISTORY.rc
file used in branch geos/develop, with modification to use SpeciesConcVV_ instead of SpeciesConc_GEOSCHEMchem_GridComp.rc
to what is used in geos/develop branch, with modification to use no analysis speciesGEOSCHEMchem_ExtData.rc
to what is used in geos/develop branch, with modification for correct CEDS path on discoverHEMCO_Config.rc
Expected changes
This is a no diff update for all simulations.
Reference(s)
None
Related Github Issue
None