Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for running GEOS-Chem 14.5.1 in GEOS #2661

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented Dec 20, 2024

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR contains no-diff updates needed for GEOS to run GEOS-Chem 14.5.1. Changes include:

  • Replace HCO_WARNING in GEOS-Chem sulfate_mod.F90 with GC_WARNING and enclose in if amIRoot to limit prints
  • Update to HISTORY.rc file used in branch geos/develop, with modification to use SpeciesConcVV_ instead of SpeciesConc_
  • Update GEOSCHEMchem_GridComp.rc to what is used in geos/develop branch, with modification to use no analysis species
  • Update GEOSCHEMchem_ExtData.rc to what is used in geos/develop branch, with modification for correct CEDS path on discover
  • Add missing UseSoilTemperature entry for SoilNOx extension in GEOS HEMCO_Config.rc

Expected changes

This is a no diff update for all simulations.

Reference(s)

None

Related Github Issue

None

@lizziel lizziel changed the base branch from main to dev/no-diff-to-benchmark December 20, 2024 20:30
@lizziel lizziel added this to the 14.5.1 milestone Dec 20, 2024
@lizziel lizziel self-assigned this Dec 20, 2024
@lizziel lizziel added no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations category: Interface to External Model Related to GEOS-Chem updates needed to interface with other models topic: GEOS ESM Related to running GEOS-Chem in the GEOS ESM labels Dec 20, 2024
@lizziel lizziel marked this pull request as ready for review December 20, 2024 20:43
@lizziel lizziel requested a review from yantosca December 20, 2024 20:43
@lizziel lizziel marked this pull request as draft December 20, 2024 20:45
@lizziel lizziel marked this pull request as ready for review December 20, 2024 20:51
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see things look good to merge. Granted that several of these modifications were made by folks at GMAO so I am assuming most of those are OK. Thanks @lizziel!

@lizziel lizziel merged commit bc66f2a into dev/no-diff-to-benchmark Dec 20, 2024
yantosca added a commit that referenced this pull request Jan 7, 2025
This merge brings updates (as of PR #2661) into the
feature/integrator-specific-handling branch.  This is necessary
in order to avoid compilation errors w/ the new HEMCO logfile
handling updates.

Signed-off-by: Bob Yantosca <[email protected]>
@lizziel lizziel deleted the bugfix/geos_run_fixes branch January 10, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Interface to External Model Related to GEOS-Chem updates needed to interface with other models no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: GEOS ESM Related to running GEOS-Chem in the GEOS ESM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants