Update HEMCO interface for changes to HEMCO error and log handling #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizziel
added
category: Feature Request
This update requires an analogous update in HEMCO Signed-off-by: Lizzie Lundgren <[email protected]>
GEOS-Chem no longer users a separate HEMCO log by default. Signed-off-by: Lizzie Lundgren <[email protected]>
lizziel
force-pushed
the
feature/clean_up_hemco_log_and_error_handling
branch
from
2f21b00 to
54b4a81
Compare
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
lizziel
added
the
topic: Structural Modifications
Signed-off-by: Lizzie Lundgren <[email protected]>
lizziel
force-pushed
the
feature/clean_up_hemco_log_and_error_handling
branch
from
3721468 to
344a4f5
Compare
amIRoot is included within verbose so is not needed. Signed-off-by: Lizzie Lundgren <[email protected]>
yantosca
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Looks good to merge alongside geoschem/HEMCO#298. Thanks @lizziel!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
Updates in this PR:
HCO_LOGFILE_OPEN,HCO_MSG, andHCO_ERRORdue to changes in Improve log flexibility in HEMCO HEMCO#298.GC_ERRORin the HEMCO interface instructing users to see the HEMCO log. GEOS-Chem no longer users a separate HEMCO log by default.NOTE: This PR should be merged at the same time as geoschem/HEMCO#298.
Expected changes
This is a no diff update.
Reference(s)
None
Related Github Issue
geoschem/HEMCO#298