Output sea flux species dry deposition velocity with DryDep collection #2606
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4563,6 +4563,9 @@ SUBROUTINE Compute_Sflx_for_Vdiff( Input_Opt, State_Chm, State_Diag, & | |
| REAL(fp), TARGET :: dflx(State_Grid%NX, & | ||
| State_Grid%NY, & | ||
| State_Chm%nAdvect ) | ||
| REAL(fp), TARGET :: dvel(State_Grid%NX, & | ||
| State_Grid%NY, & | ||
| State_Chm%nAdvect ) | ||
|
|
||
| ! Pointers and Objects | ||
| REAL(f4), POINTER :: Ptr2D(:,:) => NULL() | ||
|
|
@@ -4581,6 +4584,7 @@ SUBROUTINE Compute_Sflx_for_Vdiff( Input_Opt, State_Chm, State_Diag, & | |
| RC = GC_SUCCESS | ||
| dflx = 0.0_fp | ||
| eflx = 0.0_fp | ||
| dvel = 0.0_fp | ||
| colEflx = 0.0_fp | ||
| ThisSpc => NULL() | ||
| errMsg = '' | ||
|
|
@@ -4777,6 +4781,9 @@ SUBROUTINE Compute_Sflx_for_Vdiff( Input_Opt, State_Chm, State_Diag, & | |
| dflx(I,J,NA) = dflx(I,J,NA) + ( dep & | ||
| * State_Chm%Species(NA)%Conc(I,J,1) & | ||
| / (AIRMW / ThisSpc%MW_g) ) | ||
| ! Get dry deposition velocity in cm/s: | ||
| dvel(I,J,NA) = dvel(I,J,NA) + ( dep * State_Met%BXHEIGHT(I,J,1) * & | ||
| 1.0e+2_fp ) | ||
| ENDIF | ||
| ENDIF | ||
| ENDDO ! I | ||
|
|
@@ -4838,6 +4845,9 @@ SUBROUTINE Compute_Sflx_for_Vdiff( Input_Opt, State_Chm, State_Diag, & | |
| * State_Chm%Species(N)%Conc(I,J,1) & | ||
| / ( AIRMW / ThisSpc%MW_g ) | ||
|
|
||
| ! Get dry deposition velocity in cm/s: | ||
| dvel(I,J,N) = dvel(I,J,N) + ( State_Chm%DryDepFreq(I,J,ND) * & | ||
| State_Met%BXHEIGHT(I,J,1) * 1.0e+2_fp ) | ||
|
|
||
| IF ( Input_Opt%ITS_A_MERCURY_SIM .and. ThisSpc%Is_Hg0 ) THEN | ||
|
|
||
|
|
@@ -4858,8 +4868,10 @@ SUBROUTINE Compute_Sflx_for_Vdiff( Input_Opt, State_Chm, State_Diag, & | |
|
|
||
| ! Free species database pointer | ||
| ThisSpc => NULL() | ||
|
|
||
| ENDDO | ||
|
|
||
|
|
||
| !===================================================================== | ||
| ! Convert DFLX from 1/s to kg/m2/s | ||
| ! | ||
|
|
@@ -4891,12 +4903,11 @@ SUBROUTINE Compute_Sflx_for_Vdiff( Input_Opt, State_Chm, State_Diag, & | |
| !===================================================================== | ||
| ! Defining Satellite Diagnostics | ||
| !===================================================================== | ||
| ! Define emission satellite diagnostics | ||
| IF ( State_Diag%Archive_SatDiagnColEmis ) THEN | ||
| DO S = 1, State_Diag%Map_SatDiagnColEmis%nSlots | ||
| N = State_Diag%Map_SatDiagnColEmis%slot2id(S) | ||
| State_Diag%SatDiagnColEmis(I,J,S) = colEflx(I,J,N) | ||
|
There was a problem hiding this comment. This is a bug fix we should note in the changelog. These diagnostics must have been many times larger than they should be before this fix. There was a problem hiding this comment. @lizziel: We can test this to make sure we get zero-diff output for this diagnostic |
||
| ENDDO | ||
| ENDIF | ||
|
|
||
|
|
@@ -4907,7 +4918,7 @@ SUBROUTINE Compute_Sflx_for_Vdiff( Input_Opt, State_Chm, State_Diag, & | |
| IF ( State_Diag%Archive_SatDiagnSurfFlux ) THEN | ||
| DO S = 1, State_Diag%Map_SatDiagnSurfFlux%nSlots | ||
| N = State_Diag%Map_SatDiagnSurfFlux%slot2id(S) | ||
| State_Diag%SatDiagnSurfFlux(I,J,S) = State_Chm%SurfaceFlux(I,J,N) | ||
|
There was a problem hiding this comment. Same comment as above. Note that both of these diagnostics have bugs that are now fixed. There was a problem hiding this comment. Changelog fixed in commit d9ee2e2. |
||
| ENDDO | ||
| ENDIF | ||
|
|
||
|
|
@@ -4951,7 +4962,7 @@ SUBROUTINE Compute_Sflx_for_Vdiff( Input_Opt, State_Chm, State_Diag, & | |
| ENDIF | ||
|
|
||
| ENDDO | ||
| ENDDO | ||
| !$OMP END PARALLEL DO | ||
|
|
||
| !### Uncomment for debug output | ||
|
|
@@ -4970,7 +4981,9 @@ SUBROUTINE Compute_Sflx_for_Vdiff( Input_Opt, State_Chm, State_Diag, & | |
| ! so we don't need to do any further special handling. | ||
| !======================================================================= | ||
| IF ( Input_Opt%LGTMM .or. Input_Opt%LSOILNOX .or. & | ||
| State_Diag%Archive_DryDepMix .or. State_Diag%Archive_DryDep .or. & | ||
| State_Diag%Archive_DryDepVel .or. & | ||
| State_Diag%Archive_SatDiagnDryDepVel ) THEN | ||
|
|
||
| ! Loop over only the drydep species | ||
| ! If drydep is turned off, nDryDep=0 and the loop won't execute | ||
|
|
@@ -5016,6 +5029,36 @@ SUBROUTINE Compute_Sflx_for_Vdiff( Input_Opt, State_Chm, State_Diag, & | |
| ENDIF | ||
| ENDIF | ||
|
|
||
| !----------------------------------------------------------------- | ||
| ! HISTORY: Update dry deposition velocity [cm/s] | ||
| ! | ||
| ! Here we save the dry deposition velocities (stored in the | ||
| ! DVEL array) into the DryDepVel and SatDiagnDryDepVel History | ||
| ! diagnostics. This is necessary in order to capture the | ||
| ! air-sea deposition velocity computed by the HEMCO "SeaFlux" | ||
| ! extension for certain species. | ||
| ! | ||
| ! When using the full PBL mixing option (aka TURBDAY), the | ||
| ! DryDepVel and SatDiagnDryDepVel diagnostics will be archived | ||
| ! in drydep_mod.F90 instead. | ||
| !----------------------------------------------------------------- | ||
|
|
||
| ! Dry deposition velocity [cm/s] | ||
| IF ( State_Diag%Archive_DryDepVel ) THEN | ||
| S = State_Diag%Map_DryDepVel%id2slot(ND) | ||
| IF ( S > 0 ) THEN | ||
| State_Diag%DryDepVel(:,:,S) = dvel(:,:,N) | ||
| ENDIF | ||
| ENDIF | ||
|
|
||
| ! Satellite diagnostic dry deposition velocity (cm/s): | ||
| IF ( State_Diag%Archive_SatDiagnDryDepVel ) THEN | ||
| S = State_Diag%Map_SatDiagnDryDepVel%id2slot(ND) | ||
| IF ( S > 0 ) THEN | ||
| State_Diag%SatDiagnDryDepVel(:,:,S) = dvel(:,:,N) | ||
| ENDIF | ||
| ENDIF | ||
|
|
||
|
There was a problem hiding this comment. As I noted above, putting these here would only work for non-local mixing. Full mixing does not call this routine. |
||
| !----------------------------------------------------------------- | ||
| ! If Soil NOx is turned on, then call SOIL_DRYDEP to | ||
| ! archive dry deposition fluxes for nitrogen species | ||
|
|
@@ -5039,6 +5082,7 @@ SUBROUTINE Compute_Sflx_for_Vdiff( Input_Opt, State_Chm, State_Diag, & | |
| ThisSpc => NULL() | ||
| ENDDO | ||
| !$OMP END PARALLEL DO | ||
|
|
||
| ENDIF | ||
|
|
||
| !======================================================================= | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing these diagnostics from
drydep_modand only setting incompute_sflx_for_vdiffmeans they will always be zero if using full mixing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should now be fixed in commits d9ee2e2 and c7cfcfa.