Prevent History diagnostic collection duration from being shorter than frequency #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
History/history_mod.F90 - Added error trap to make sure that the collection duration (which specifies when it's time to write a new file) is never shorter than the collection frequency (which specifies the diagnostic time interval). This prevents an error that can result in empty diagnostic files. - Updated error messages to use "YYYYMMDD hhmmss" notation CHANGELOG.md - UPdated accordingly Signed-off-by: Bob Yantosca <[email protected]>
yantosca
added
topic: Diagnostics
|
All GEOS-Chem Classic integration tests (except tagCO) passed. This is due to a known restart file issue introduced in PR #2510. ==============================================================================
GEOS-Chem Classic: Execution Test Results
CodeDir : a8aeb02 GEOS-Chem update: Merge PR #2578 (Fixes for GCHP adjoint )
GEOS-Chem : 5c8cf0754 Bug fix: Prevent collection duration from being shorter than frequency
HEMCO : deaa192 HEMCO 3.10.0 release
Cloud-J : f8a2b7f Update version number for 8.0.1 release
HETP : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
Using 24 OpenMP threads
Number of execution tests: 30
Submitted as SLURM job: 59474791
==============================================================================
...
gc_4x5_merra2_tagCO.................................Execute Simulation....FAIL
...
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 29
Execution tests failed: 1
Execution tests not yet completed: 0Also all tests were identical with the previous integration test except for:
A rerun of the integration tests showed zero differences in the fullchem_alldiags test. |
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
CodeDir : 7c2d8e2 GEOS-Chem update: Merge PR #2578 (Fixes for GCHP adjoint )
MAPL : 9ad63ae Merge PR #37 containing update to vertically flip imports with dimensionless pressure proxy lev coordinates
GMAO_Shared : 4ddb3ec Merge pull request #2 from geoschem/feature/mapl-upgrade
ESMA_cmake : ad5deba Added ecbuild as a submodule of ESMA_cmake
gFTL-shared : 4b82492 Merge branch 'upstream_v1.5.0' into feature/v1.5.0
FMS : 259759d Merge pull request #3 from geoschem/feature/update_gmao_libs
FVdycoreCubed : af42462 Merge PR #8 (Add PLEadv diagnostic for offline advection in GCHP)
geos-chem : 5c8cf0754 Bug fix: Prevent collection duration from being shorter than frequency
HEMCO : deaa192 HEMCO 3.10.0 release
yaFyaml : 19afe50 Merge branch 'upstream_v1.0.4' into feature/v1.0.4
pFlogger : 2c4b724 Merge branch 'upstream_v1.9.1' into feature/v1.9.1
Cloud-J : f8a2b7f Update version number for 8.0.1 release
HETP : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
Number of execution tests: 12
Submitted as SLURM job: 59476176
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%All tests were zero-diff w/r/t the prior integration tests. |
msulprizio
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution:
Describe the update
This PR addresses the problem reported in #2572 by @Mbavhi1, in which a collection duration setting shorter than the collection frequency, such as:
does not halt the run with an error. This can result in empty diagnostic files (as the frequency setting determines the writing of data to file and the duration determines when new files are created).
Expected changes
An error message is now displayed if duration is shorter than frequency, and the run will halt:
Related Github Issue