Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass non-zero Ca2, Mg, and K cations to HETP #2398

Merged
merged 1 commit into from
Jul 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

### Changed
- Copy values from `State_Chm%KPP_AbsTol` to `ATOL` and `State_Chm%KPP_RelTol` to `RTOL` for fullchem and Hg simulations
- Change previously zero Ca2, K, and Mg cation values passed to HETP to scaled SALA species concentrations

### Fixed
- In `Headers/roundoff_mod.F90`, first cast and then only round off if `places > 0`
Expand Down
34 changes: 11 additions & 23 deletions GeosCore/aerosol_thermodynamics_mod.F90
Original file line number Diff line number Diff line change
Expand Up @@ -673,29 +673,17 @@ SUBROUTINE DO_ATE( Input_Opt, State_Chm, State_Diag, &
! Total Cl- [mole/m3]
TCL = ACL + GCL

!====================================================================
! NOTE: As of 11/2007, ISORROPIAII does not conserve mass when Ca,K,Mg
! are non-zero. If you would like to consider Ca, K, Mg from seasalt
! and dust, then ISORROPIA II ISRP4F routines must be debugged.
! (hotp, bmy, 2/1/10)
! This still applies in HETP (ewl, 4/22/2024)
!
! ! Total Ca2+ (1.16% by weight of seasalt) [mole/m3]
! TCA = Spc(id_SALA)%Conc(I,J,L) * 0.0116e+0_fp * 1.d3 /
! ( 40.08e+0_fp * VOL )
!
! ! Total K+ (1.1% by weight of seasalt) [mole/m3]
! TK = Spc(id_SALA)%Conc(I,J,L) * 0.0110e+0_fp * 1.d3 /
! ( 39.102e+0_fp * VOL )
!
! ! Total Mg+ (3.69% by weight of seasalt) [mole/m3]
! TMG = Spc(id_SALA)%Conc(I,J,L) * 0.0369e+0_fp * 1.d3 /
! ( 24.312e+0_fp * VOL )
!====================================================================
!! Set Ca, K, Mg to zero for time being (hotp, bmy, 2/1/10)
!TCA = 0e+0_fp
!TK = 0e+0_fp
!TMG = 0e+0_fp
! Total Ca2+ (1.16% by weight of seasalt) [mole/m3]
TCA = Spc(id_SALA)%Conc(I,J,L) * 0.0116e+0_fp * 1.d3 / &
( 40.08e+0_fp * VOL )

! Total K+ (1.1% by weight of seasalt) [mole/m3]
TK = Spc(id_SALA)%Conc(I,J,L) * 0.0110e+0_fp * 1.d3 / &
( 39.102e+0_fp * VOL )

! Total Mg+ (3.69% by weight of seasalt) [mole/m3]
TMG = Spc(id_SALA)%Conc(I,J,L) * 0.0369e+0_fp * 1.d3 / &
( 24.312e+0_fp * VOL )

! Compute gas-phase NO3
IF ( id_HNO3 > 0 ) THEN
Expand Down