Fix issues in cubed-sphere regridding #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled compare plots for 2D variables between two different cube-sphere resolutions.
Cube-sphere dimensions' sequence was reverse. Enabling versatile reshaping handling.
Correct automatic regridding decision process to match documentation.
3 tasks
yantosca
changed the title
yantosca
added
topic: Cubed-Sphere Grid
yantosca
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Thanks @yuanjianz for looking into this. I'll test it and then merge into the gcpy dev branch.
yantosca
added a commit
that referenced
this pull request
Apr 26, 2024
This merge brings PR # (Fix issues in cubed-sphere regridding, by @yuanjianz) into the GCPy 1.5.0 development stream. This PR does the following: 1. Now cube-sphere regridding in file_regrid would have correct shape of value array for single level plotting in single_panel. 2. Now compare_single_level will automatically choose the higher resolution between two standard cube-sphere grids, and also having correct unflipped absdiff and fracdiff. 3. Now will not trigger renaming error when 2D data (Emissions, column AODs) that needs regridding is passed to compare_single_level. 4. Delete code for quiting benchmark (which is already included in dev branch) Signed-off-by: Bob Yantosca <[email protected]>
yantosca
added a commit
that referenced
this pull request
Apr 26, 2024
gcpy/file_regrid.py - Add if statements to test if lat_bnds and lon_bnds are in the data variables of the dataset before trying to drop them from the dataset. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]> Now allow make_regridder_L2L to use nearest_s2d regridding gcpy/regrid.py -
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Yuanjian Zhang
Institution: WashU
Confirm you have reviewed the following documentation
Describe the update
Fixed bugs about cube-sphere regridding formatting mentioned in #310
Expected changes
file_regridwould have correct shape of value array for single level plotting insingle_panel.compare_single_levelwill automatically choose the higher resolution between two standard cube-sphere grids, and also having correct unflippedabsdiffandfracdiff. (see the figure below)compare_single_level.Reference(s)
None
Related Github Issue(s)
#310