Fix bugs in GCC vs GCHP transport tracer benchmark mass tables #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizzie Lundgren <[email protected]>
lizziel
added
category: Bug
The call to make the benchmark mass tables was missing from the transport tracer run script. Signed-off-by: Lizzie Lundgren <[email protected]>
lizziel
force-pushed
the
bugfix/tt_benchmarK_gcc_vs_gchp_mass_tables
branch
from
4007bc6 to
9940b8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR fixes two bugs that were preventing generation of the GCC vs GCHP mass tables in the transport tracer benchmark. One of the problems was the reference restart path used the GCHP run directory rather than GCC. This bug went undetected because of the second problem, which omitted the call to generate the GCC vs GCHP mass tables altogether.
These problems also went under the radar because GCC vs GCHP global mass tables are not posted as part of the 1-year benchmark tables per version. The tables can now be generated and so should be included on the GEOS-Chem version pages.
Expected changes
GCC vs GCHP global mass tables with now be generated in the 1-yr transport tracer benchmark.
Reference(s)
None
Related Github Issue(s)
None