Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update regridding docs #205

Merged
merged 4 commits into from
Mar 1, 2023

Conversation

kilicomu
Copy link
Contributor

@kilicomu kilicomu commented Feb 27, 2023

First pass at reworking the docs to reflect changes in #190 -

  • Updated the main regridding documentation to describe use of the new regrid_restart_file submodule
  • Updated the overview of capabilities documentation to reference the new regrid_restart_file submodule
  • Trimmed away much of the old gridspec and sparselt documentation

I'm not sure how the regridding for plotting works with stretched grid files, so I left that section in the regridding docs untouched (just moved it).

Happy to take suggestions, of course!

@lizziel
Copy link
Contributor

lizziel commented Feb 27, 2023

I plan on testing out the instructions in this PR's doc updates. I'll give the go ahead to merge when I'm done.

@lizziel lizziel self-requested a review February 27, 2023 18:44
Copy link
Contributor

@lizziel lizziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay upon reading. I'm going to merge and clean up as needed post-merge.

@lizziel lizziel merged commit ab97165 into geoschem:docs/dev Mar 1, 2023
$ python -m gcpy.regrid_restart_file \
GEOSChem.Restart.20190701_0000z.c48 \
c48_to_c120_stretched_weights.nc \
GEOSChem.Restart.20190701_0000z.c48
Copy link
Contributor

@lizziel lizziel Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also have stretched grid, target lat, and target lon passed? When I execute as is I don't get the stretch factor and target lat/lon global attributes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right. That's the whole point of the update - can't believe I missed that.

@lizziel
Copy link
Contributor

lizziel commented Mar 1, 2023

The latest doc updates, plus a few I put on top, are now here.

@yantosca yantosca added this to the 1.3.3 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants