Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to generate CH4 benchmark output #186

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

msulprizio
Copy link
Contributor

This PR adds the benchmark type "CH4Benchmark" for validating GEOS-Chem CH4 simulations. This option utilizes the existing benchmark code and a reduced set of options from the FullChemBenchmark type (concentration plots, emission plots, emission tables, mass tables, OH metrics).

Also pass bmk_type to additional routines where needed.

Signed-off-by: Melissa Sulprizio <[email protected]>
Benchmark plots and tables for CH4 simulations can now be generated by
passing benchmark_type='CH4Benchmark'. This option currently utilizes
the existing routines for the FullChemBenchmark option. We may want to
consider removing "FullChem" and making those routines more generic in
the future.

For now, just the concentration plots, emission plots, emission tables,
mass tables, and OH metrics work for the CH4Benchmark option.

Signed-off-by: Melissa Sulprizio <[email protected]>
@msulprizio msulprizio added category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output labels Dec 20, 2022
@msulprizio msulprizio requested a review from yantosca December 20, 2022 18:30
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've flagged a place where we can use the util.read_config_file function to read the config file instead of using yaml.load etc, to be consistent with other usage.

Other than this, looks great to merge!

gcpy/benchmark.py Show resolved Hide resolved
@msulprizio msulprizio added this to the 1.4.0 milestone Dec 22, 2022
@msulprizio msulprizio merged commit 527ed75 into dev Dec 22, 2022
@msulprizio msulprizio deleted the feature/ch4-benchmarks branch December 22, 2022 21:20
@yantosca yantosca modified the milestones: 1.4.0, 1.3.3 Mar 9, 2023
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been applied in GCPy 1.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants