Skip to content

Commit

Permalink
Merge PR #240 (Fix issue for GCHP in model vs. obs plots)
Browse files Browse the repository at this point in the history
This merge brings PR #240 (Fix issue where wrong GCHP grid boxes
were being looked up in models vs. obs plots, by @yantosca) into
the GCPy 1.4.0 development stream.

This fixes an issue with the models vs. observations benchmark
plots where the wrong GCHP grid box was being looked up for a
given (lon, lat, alt) value.  We now use the cubed-sphere
functions in gcpy/cstools.py to do the lookup properly.

Signed-off-by: Bob Yantosca <[email protected]>
  • Loading branch information
yantosca committed Jul 27, 2023
2 parents 9d0d089 + 5264eeb commit 6967acc
Show file tree
Hide file tree
Showing 6 changed files with 339 additions and 141 deletions.
5 changes: 3 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- Added `benchmark/modules/GC_72_vertical_levels.csv` file
- Added `multi_index_lat` keyword to `reshape_MAPL_CS` function in `gcpy/util.py`
- Added FURA to `emission_species.yml` and `benchmark_categories.yml`
- Added new routine `format_number_for_table` in `util.py`
- Added new routine `format_number_for_table` in `gcpy/util.py`
- Added module `gcpy/cstools.py` with utility functions for cubed-sphere grids
- Added new routine `verify_variable_type` function in `gcpy/util.py`

### Changed
- Simplified the Github issues templates into two options: `new-feature-or-discussion.md` and `question-issue.md`
Expand All @@ -41,7 +42,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
### Fixed
- Generalized test for GCHP or GCClassic restart file in `regrid_restart_file.py`
- Fixed bug in transport tracer benchmark mass conservation table file write
- Routine `create_display _name` now splits on only the first `_` in species & diag names
- Routine `create_display_name` now splits on only the first `_` in species & diag names

### Removed
- Removed `gchp_is_pre_13_1` arguments & code from benchmarking routines
Expand Down
Loading

0 comments on commit 6967acc

Please sign in to comment.