Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved GCC specific build configuration to this repo #4

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Moved GCC specific build configuration to this repo #4

merged 2 commits into from
Jul 31, 2020

Conversation

LiamBindle
Copy link
Contributor

This PR moves the old scripts to configure GEOS-Chem Classic to this repo. This does the following

  • Builds without a run directory (which was breaking quick-build and build-matrix wheen they included "install" in the build step
  • Should be identical to how the old GEOS-Chem Classic build system looked from the users perspective
  • Simplifies the build system in the GEOS-Chem repo

There's an accompanying PR for GEOS-Chem:

@LiamBindle LiamBindle mentioned this pull request Jul 31, 2020
Closed
@LiamBindle LiamBindle mentioned this pull request Jul 31, 2020
Closed
@LiamBindle
Copy link
Contributor Author

I believe this PR is ready to merge. I'll hold off merging--would someone be able to review and merge? Let me know if you have any questions. I will be away Tuesday--Friday morning next week.

@yantosca
Copy link
Contributor

yantosca commented Jul 31, 2020 via email

@LiamBindle LiamBindle mentioned this pull request Jul 31, 2020
Closed
@yantosca yantosca merged commit 62b6925 into dev/13.0.0 Jul 31, 2020
@msulprizio msulprizio deleted the dev/move-classic-config-to-wrapper branch October 23, 2020 18:49
lizziel added a commit that referenced this pull request Nov 28, 2023
@lizziel
Update Cloud-J submodule
3e12bec 
  > Merge pull request #4 from jimmielin/hplin/fix_decl_ifort
  > Updates for using MAPL in Cloud-J
  > Include compile definition for MODEL_GEOSCHEM when building in GCHP

Signed-off-by: Lizzie Lundgren <[email protected]>
lizziel added a commit that referenced this pull request Dec 1, 2023
@lizziel
Update Cloud-J submodule
7d3bcca 
  > Merge pull request #4 from jimmielin/hplin/fix_decl_ifort
  > Updates for using MAPL in Cloud-J
  > Include compile definition for MODEL_GEOSCHEM when building in GCHP

Signed-off-by: Lizzie Lundgren <[email protected]>
lizziel added a commit that referenced this pull request Dec 5, 2023
@lizziel
Update Cloud-J submodule
17aca67 
  > Merge pull request #4 from jimmielin/hplin/fix_decl_ifort
  > Updates for using MAPL in Cloud-J
  > Include compile definition for MODEL_GEOSCHEM when building in GCHP

Signed-off-by: Lizzie Lundgren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LiamBindle @yantosca