-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl Display for Wkt #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll wait a couple days before merging in case anybody else wants to weigh in.
bors try
tryBuild failed: |
Could you please run cargo fmt and push up the changes? |
Done! |
categulario
added a commit
to categulario/wkt
that referenced
this pull request
Apr 1, 2022
This requires Display to be implemented (see georust#86) but it shows something that otherwise is quite hard to learn how to do.
3 tasks
lnicola
approved these changes
Apr 2, 2022
bors r+ |
Build succeeded: |
categulario
added a commit
to categulario/wkt
that referenced
this pull request
Apr 3, 2022
This requires Display to be implemented (see georust#86) but it shows something that otherwise is quite hard to learn how to do.
bors bot
added a commit
that referenced
this pull request
Apr 14, 2022
89: Easier serialization of wkt with ToWkt::wkt_string/write_wkt r=urschrei a=michaelkirk - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. - [x] I ran cargo fmt --- Fixes #55 - adds an easier API to serialize a geo-type. ~~Depends on #86, so merge that first.~~ Merged! ~~partially conflicts with #88, because I'm relying on the `ToWkt` trait.~~ superseded! Co-authored-by: Michael Kirk <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.md
if knowledge of this change could be valuable to users.to address #83 and make it easier to go from Wkt to string representation. Includes test