Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing incircle documentation #30

Closed
DelusionalLogic opened this issue May 24, 2023 · 1 comment · Fixed by #31
Closed

Confusing incircle documentation #30

DelusionalLogic opened this issue May 24, 2023 · 1 comment · Fixed by #31

Comments

@DelusionalLogic
Copy link

The documentation for incircle says it will be positive when the pd is OUTSIDE the circle. From my experimentation that seems incorrect. It would seem that it's negative if the point is outside, which would also align with documentation of predicates.c.
@urschrei urschrei mentioned this issue May 25, 2023
Merged
@urschrei
Copy link
Member

Oops, sorry about that!

bors bot added a commit that referenced this issue May 25, 2023
@bors @urschrei
Merge #31
6fa7015 
31: Fix incircle docs r=urschrei a=urschrei

Fixes #30

Co-authored-by: Stephan Hügel <[email protected]>
@bors bors bot closed this as completed in 830b78d May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incircle docs georust/robust
2 participants
@urschrei @DelusionalLogic