Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose feature for gdal with bindgen #190

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

michaelkirk
Copy link
Member

@michaelkirk michaelkirk commented Jan 10, 2024

This is necessary for linking against gdal versions whose bindings
aren't yet included in gdal-sys, which is common when using a newly
released gdal.

Also removed redundant gdal-sys dependency - gdal already includes that,
and geozero doesn't use it directly.

edit: note this won't pass CI until #189 is merged update: rebased!

@michaelkirk michaelkirk mentioned this pull request Jan 10, 2024
This is necessary for linking against gdal versions whose bindings
aren't yet included in gdal-sys, which is common when using a newly
released gdal.

Also removed redundant gdal-sys dependency - gdal already includes that,
and geozero doesn't use it directly.
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, one minor nit, and can be merged IMO

geozero/Cargo.toml Outdated Show resolved Hide resolved
Co-authored-by: Yuri Astrakhan <[email protected]>
@nyurik
Copy link
Member

nyurik commented Jan 11, 2024

thx, feel free to merge

@michaelkirk michaelkirk merged commit 6c820ad into georust:main Jan 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants