Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common web services. #1

Open
2 of 3 tasks
groteworld opened this issue Jan 20, 2015 · 5 comments
Open
2 of 3 tasks

Add common web services. #1

groteworld opened this issue Jan 20, 2015 · 5 comments

Comments

@groteworld
Copy link
Member

groteworld commented Jan 20, 2015

I typically use the google v3 api and osm. what other ones should be addressed first?

Web Services to support:

  • Google v3 API
  • OpenStreetMap
  • OpenCage

EDIT: ADD OPENCAGE AND IMMEDIATELY CLOSE IT THANKS TO @urschrei ;)

@calvinmetcalf
Copy link
Member

Google maps has some pretty strict limits on what you can do with results
from their geocoder, mainly you can only display them on Google maps (not
esri, leaflet or anything else) and you can only store data for performance
purposes for at most 90 days

On Tue, Jan 20, 2015, 4:10 PM Blake Grotewold [email protected]
wrote:

I typically use the google v3 api and osm. what other ones should be
addressed first?

Web Services to support:

  • Google v3 API
  • OpenStreetMap


Reply to this email directly or view it on GitHub
#1.

@frewsxcv
Copy link
Member

And while I think Google's legal usage policies about geocoding are dumb, I still think it's still valuable to implement it as an option for this library. If you're looking for other geocoding services, you can check out what geopy has listed: https://github.com/geopy/geopy

@freyfogle
Copy link
Contributor

Hi,

Google is great, but the lack of openness of the data, and thus limitations on what is possible with it, are a major turn off. One alternative is the OpenCage Geocoder. We (I'm one of the people behind it) provide a single API to various open geocoders. OpenStreetMap of course, but also several smaller, country-specific services.
I'd love to see us integrated into this library. Unfortunately though I don't know rust. Happy to pay someone for a few hours of their time to do the work of creating a pull request. Is that something anyone on this thread would be open to?

@urschrei
Copy link
Member

urschrei commented Apr 9, 2018

Hi Ed,
Yep, we can have a look at incorporating it (it looks like nobody ever kicked off the geo-coding functionality anyway, so you'd be one of the first available services).

@urschrei
Copy link
Member

urschrei commented Apr 9, 2018

See #4 for a PR relating to this.

bors bot added a commit that referenced this issue Aug 20, 2019
22: Implement Openstreetmap provider r=urschrei a=pjsier

Thanks for putting this library together! I took a stab at implementing an OpenStreetMap provider here since it was listed in #1 

I tried to follow the patterns from the OpenCage provider and used the builder pattern for specifying additional parameters, but I'm new to Rust so let me know if anything seems off. I'd like to use the `InputBounds` struct for the `viewport` parameter here, but wanted to check and see what the best way of restructuring that would be

Co-authored-by: pjsier <[email protected]>
urschrei pushed a commit that referenced this issue May 1, 2024
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants