Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract PostGIS integration from 'geo' to a separate 'geo-postgis' crate. #466

Merged
merged 2 commits into from
May 25, 2020

Conversation

frewsxcv
Copy link
Member

  • Reduces geo's full dependency tree quite a bit
  • Our PostGIS compatibility feature in geo lived in geo::algorithms, but is it really an algorithm? It's really more just glue between geo-types and postgis
  • We can move this out to a separate repo if we want

Thoughts?

readme = "../README.md" # TODO
keywords = ["gis", "geo", "geography", "geospatial"] # TODO
description = "" # TODO
edition = "2018"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fill in the TODOs above if this PR gets approved

@frewsxcv frewsxcv changed the title Extract PostGIS integration from 'geo' to a separate crate. Extract PostGIS integration from 'geo' to a separate 'geo-postgis' crate. May 23, 2020
Copy link
Member

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense to me. 👍

Copy link
Member

@urschrei urschrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@frewsxcv
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 25, 2020

Build succeeded:

@bors bors bot merged commit 70ccafc into master May 25, 2020
@frewsxcv frewsxcv deleted the frewsxcv-postgis branch May 25, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants