Migrate Line/LineString to be a series of Coordinates (not Points). #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewsxcv
force-pushed
the
frewsxcv-linestring-line-coords
branch
from
e9a720b to
2099592
Compare
frewsxcv
changed the title
frewsxcv
force-pushed
the
frewsxcv-linestring-line-coords
branch
from
d621246 to
4e7532a
Compare
|
A pretty big pull request, but it should be ready to go now! I'll squash before approving |
urschrei
approved these changes
Jun 23, 2018
geo-types/src/coordinate.rs
Outdated
| where | ||
| T: CoordinateType, | ||
| { | ||
| /// Returns the dot product of the two points: |
There was a problem hiding this comment.
should this be "…of the two coordinates"?
geo-types/src/coordinate.rs
Outdated
| self.x * coord.x + self.y * coord.y | ||
| } | ||
|
|
||
| /// Returns the cross product of 3 points. A positive value implies |
geo-types/src/line.rs
Outdated
| @@ -141,8 +141,27 @@ where | |||
| /// # ); | |||
| /// ``` | |||
| /// | |||
| /// [determinant]: https://en.wikipedia.org/wiki/Determinant | |||
There was a problem hiding this comment.
FYI: links have to be inline for RLS
geo-types/src/line_string.rs
Outdated
| /// ``` | ||
| /// | ||
| /// You can iterate over the points in the `LineString` | ||
| /// You can iterate over the coordintes in the `LineString` |
frewsxcv
changed the title
frewsxcv
force-pushed
the
frewsxcv-linestring-line-coords
branch
5 times, most recently
from
cfac035 to
f312406
Compare
frewsxcv
force-pushed
the
frewsxcv-linestring-line-coords
branch
from
f312406 to
b82b3a5
Compare
|
bors r=urschrei |
bors bot
added a commit
that referenced
this pull request
Jun 23, 2018
244: Migrate Line/LineString to be a series of Coordinates (not Points). r=urschrei a=frewsxcv Relevant conversation in #15. This is a breaking change for `geo-types`. I'm _not_ planning to publish a release if this merges. I have a couple other breaking changes I'd like to consider before bumping the Rust geo ecosystem. Co-authored-by: Corey Farwell <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant conversation in #15.
This is a breaking change for
geo-types.I'm not planning to publish a release if this merges. I have a couple other breaking changes I'd like to consider before bumping the Rust geo ecosystem.