Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rstar and robust dependencies #1030

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Bump rstar and robust dependencies #1030

merged 1 commit into from
Jul 13, 2023

Conversation

urschrei
Copy link
Member

@urschrei urschrei commented Jul 9, 2023

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

@urschrei
Copy link
Member Author

urschrei commented Jul 9, 2023

Ah yes, need to bump CI containers first of course.

@urschrei
Copy link
Member Author

bors retry

@urschrei
Copy link
Member Author

bors cancel

@urschrei
Copy link
Member Author

bors retry

@urschrei
Copy link
Member Author

This ended up being slightly more invasive than I thought it would be as I had to add an use-rstar-11 feature and corresponding impls too. If people would prefer a more comprehensive CHANGES entry lmk

geo/CHANGES.md Outdated
@@ -4,6 +4,7 @@

* Implement "Closest Point" from a `Point` on a `Geometry` using spherical geometry. <https://github.com/georust/geo/pull/958>
* Bump CI containers to use libproj 9.2.1
* Bump rstar and robust dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Bump rstar and robust dependencies
* BREAKING: Bump rstar and robust dependencies

Since it's a major version bump of a public API, this is a breaking change, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(breaking for geo, non-breaking for geo-types)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you add a note to the geo-types CHANGES as well?

@urschrei
Copy link
Member Author

bors r=michaelkirk

@bors
Copy link
Contributor

bors bot commented Jul 13, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 31888c0 into georust:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants