Allow reading block-size of Rasters #67
Conversation
1. implemented GetBlockSize 2. added feature flag "gdal_2_2" to enable recent GDAL functions. 3. implemented GetActualBlockSize (behind "gdal_2_2" flag)
|
Thanks for your contribution, @rmanoka! Code looks good to me. Would you mind adding some tests for the new functions and resolve the conflicting files? |
|
@pka Sure, I'll add tests and resolve There are a couple of minor issue with #68 that has been merged recently:
Any ideas? |
|
Actually, the GDAL docs say it already yields an array of block-size dimensions; so the user only needs to use |
+ added `x_size()`, `y_size()`, and `size()` to `RasterBand` + added tests
| @@ -42,6 +40,31 @@ impl <'a> RasterBand<'a> { | |||
| (size_x as usize, size_y as usize) | |||
| } | |||
|
|
|||
| /// Get x-size of the band | |||
| pub fn x_size(&self) -> usize { | |||
| let out; | |||
There was a problem hiding this comment.
Nit: let out = unsafe { gdal_sys::GDALGetRasterBandXSize(self.c_rasterband); }
|
Ping @pka? |
|
|
|
Works for me. Let's wait for the |
This PR allows efficient streaming of raster by reading (using already existing
read_as) along block boundaries. To get block size, callblock_sizeon aRasterBand.Additionally, we also add feature flag
gdal_2_2that enables the corresponding feature ingdal-syscrate to pull in features from GDAL >= 2.2. Using this, we provideactual_block_sizefunction behind this feature gate to be used if required.List of what is implemented: