Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hdf5-metno fork and netcdf-sys #568

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

magnusuMET
Copy link
Member

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

  • Use the netcdf-sys crate to automatically link the correct netcdf-c
  • Use the more updated fork of hdf5-rust, as the original crate has not had a release for quite some time Fork of repository aldanor/hdf5-rust#295

@lnicola
Copy link
Member

lnicola commented Oct 3, 2024

r? @weiznich

Copy link
Contributor

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me 👍

(Seems like I managed to screw up the merge of GiGainfosystems#1, I expected that to be included in #517)

@lnicola
Copy link
Member

lnicola commented Oct 5, 2024

Thanks, this does clean up the build script a little!

@lnicola lnicola merged commit 29fea61 into georust:master Oct 5, 2024
14 checks passed
@magnusuMET magnusuMET deleted the use_hdf5_netcdf_sys_crates branch October 7, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants