Implemented Feature::set_field_null
#501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
reviewed
Dec 20, 2023
src/vector/feature.rs
Outdated
| fn test_field_set_null() { | ||
| let ds = Dataset::open(fixture("roads.geojson")).unwrap(); | ||
|
|
||
| for mut layer in ds.layers() { |
There was a problem hiding this comment.
I think we can limit this to a single layer and feature.
|
I was too afraid to check in #427, looked at the docs now, but still have no idea. Does anyone know the difference between Does the latter actually remove the field value in formats like GeoJSON? |
|
No, I would have merged it, but unsetting all fields of all features in all layers seems a bit excessive. But it's only 21 features, so feel free to merge 🙂. |
|
I simplified the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Closes #427
Credit to @nms-scribe