-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to get owned reference to inner geometry. #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urschrei
reviewed
May 14, 2022
@urschrei Any further thoughts about this PR? |
rmanoka
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: it's a useful API, and the PR doesn't add any new unsafe code.
* 'fix/269' of github.com:metasim/gdal: (21 commits) Fix formatting issues use match for error, try without casts to c_double Add functions to enumerate Drivers correct `method_name` in `root_group` add mdarray to CHANGES.md clippy lints more functionality and less memory leaks for mdarray gdalmd module fixes Temporary remove example, not sure how to fix clippy warning only build mdarray if gdal >3.1 only build mdarray if gdal >3.1 only build mdarray if gdal >3.1 cargo fmt -- --emit files rustfmt add mdarray example Add test data for mdarrays Added basic support for mdarrays added mdarray added root_group function Add changes ...
@rmanoka FYI, build is now completing successfully. |
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.md
if knowledge of this change could be valuable to users.Closes #269