Add RasterBand #24
Add RasterBand #24
Conversation
…asterband.rs. Added more rasterband functions and tests.
|
This looks awesome! Will review it later today |
| } | ||
|
|
||
|
|
||
| pub fn get_rasterband<'a>(&'a self, band_index: isize) -> Option<RasterBand<'a>> { |
There was a problem hiding this comment.
It's Rust convention to not have get_ prefixes on getters, but it's up to you.
https://doc.rust-lang.org/style/style/naming/README.html#gettersetter-methods-rfc-344
There was a problem hiding this comment.
If you do decide to change this, there are other get_ cases below that could also be changed.
There was a problem hiding this comment.
Maybe that's the price for working with multiple languages at the same time ;) I will remove all get_prefixes.
|
Looks great! Feel free to merge. On a separate note, you seem to be leading the rust-gdal effort at the moment, so I'm going to leave it up to you for the direction of this library :) If I had more time, I'd love to also work on it, but I'm a bit busy currently. I'll still be happy to do reviews though |
|
I also just granted crates.io publish rights to the georust/core team, so you should be able to publish your changes whenever you want. |
|
Thanks :) I guess we will have to see how much time i can spend for rust-gdal. But i will try to do my best :) |
|
Latest commit looks good. Want me to merge and |
This adds a
struct RasterBandand moves all related functions fromDatasettoRasterBand.I'm not sure if the read/write functions in Dataset should be removed or stay as shortcuts. As requesting a
RasterBandfrom aDatasetshould return anOption<RasterBand>i adapted the shortcuts to reflect this...Additionally i added some more Rasterband specific functions and implemented Metadata #20 for RasterBand.