Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bors integration #208

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Fix bors integration #208

merged 3 commits into from
Aug 6, 2021

Conversation

michaelkirk
Copy link
Member

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

I think the elements in status need to match all the GH Action job names we require to succeed.

@michaelkirk
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 5, 2021
@lnicola
Copy link
Member

lnicola commented Aug 5, 2021

Is it stuck?

@michaelkirk
Copy link
Member Author

bors try-

@michaelkirk
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 5, 2021
@bors
Copy link
Contributor

bors bot commented Aug 5, 2021

try

Build failed:

@michaelkirk michaelkirk changed the title Update bors.toml Fix bors integration Aug 5, 2021
@michaelkirk
Copy link
Member Author

Build failed:

woohoo! I think that's actually what we want to see at this point, because it means bors is working. The clippy lint causing the build failure is fixed in #205.

So you can merge #205 first, or manually merge this while the build is still broken, or whatever else you like.

@lnicola
Copy link
Member

lnicola commented Aug 5, 2021

bors r+

bors bot added a commit that referenced this pull request Aug 5, 2021
208: Fix bors integration r=lnicola a=michaelkirk

- [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md).
- [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.
---

I think the elements in `status` need to match all the GH Action job names we require to succeed.



Co-authored-by: Michael Kirk <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 5, 2021

Timed out.

@michaelkirk
Copy link
Member Author

bors retry

😒

bors bot added a commit that referenced this pull request Aug 5, 2021
208: Fix bors integration r=lnicola a=michaelkirk

- [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md).
- [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.
---

I think the elements in `status` need to match all the GH Action job names we require to succeed.



Co-authored-by: Michael Kirk <[email protected]>
I think:
trying is for bors try
staging is for bors r+
@bors
Copy link
Contributor

bors bot commented Aug 6, 2021

Canceled.

@michaelkirk
Copy link
Member Author

bors retry

😒 🤖

@bors
Copy link
Contributor

bors bot commented Aug 6, 2021

Build succeeded:

@bors bors bot merged commit 6a34a69 into master Aug 6, 2021
@lnicola lnicola deleted the michaelkirk-patch-2 branch August 6, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants