Add Feature::c_feature
#192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
force-pushed
the
feature-c-feature
branch
from
694224a to
488d3d7
Compare
lnicola
force-pushed
the
feature-c-feature
branch
from
488d3d7 to
a199be0
Compare
|
r? @jdroenner |
|
r? anyone |
|
we could think about the pointer exposure in general. maybe such a method should be unsafe? |
|
I wanted to do a follow-up PR for that. I don't think they need to be unsafe. In rust you, the place where you dereference a pointer is unsafe, not where you create it. So if the feature is valid, there's no reason for this method to be unsafe. And if it's not valid, it was created by unsafe code. |
lnicola
force-pushed
the
feature-c-feature
branch
from
a199be0 to
f1ab944
Compare
|
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.