Add Dataset::build_overviews #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
force-pushed
the
dataset-build-overviews
branch
from
cd24087 to
5623d4d
Compare
lnicola
force-pushed
the
dataset-build-overviews
branch
from
5623d4d to
3a92302
Compare
michaelkirk
reviewed
Feb 22, 2021
src/dataset.rs
Outdated
| /// | ||
| /// [`GDALBuildOverviews`]: https://gdal.org/doxygen/gdal_8h.html#a767f4456a6249594ee18ea53f68b7e80 | ||
| pub fn build_overviews( | ||
| &self, |
There was a problem hiding this comment.
In line with #161, I wonder if @rmanoka or @jdroenner have thoughts about whether this should be &mut.
There was a problem hiding this comment.
i guess &mut is the better choice.
frewsxcv
approved these changes
Feb 22, 2021
src/dataset.rs
Outdated
| /// | ||
| /// [`GDALBuildOverviews`]: https://gdal.org/doxygen/gdal_8h.html#a767f4456a6249594ee18ea53f68b7e80 | ||
| pub fn build_overviews( | ||
| &self, |
There was a problem hiding this comment.
Should this take &mut self if it's modifying self.c_dataset?
There was a problem hiding this comment.
Lol @michaelkirk just commented about the same thing :)
|
Updated. Unrelated, tests fail intermittently on my computer: process didn't exit successfully: (but only when |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.