Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation #158

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Conversation

rmanoka
Copy link
Contributor

@rmanoka rmanoka commented Feb 2, 2021

Added documentations for Dataset and RasterBand, and fixed cfg() for some of the open_ex flags (it wasn't enabled on gdal 3.0 and above).

Open question: how to refer to GDAL documentations from our docs? For many functions, the relevant docs are doxygen links (eg. GDALOpenEx) which could break if it is regenerated upstream (and annoying to update).


  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

+ add docs for `Dataset` and `RasterBand`.
+ fix `cfg()` for GDAL OpenEx flags.
@jdroenner
Copy link
Member

cool!more documentation is always good. I don't have an answer to the doxygen links. I guess we could link the doxygen startpage and leave the user to find the method?

@rmanoka
Copy link
Contributor Author

rmanoka commented Feb 4, 2021

Broken links lead to the start page (via a 404) anyway; hopefully the text of the link tells the user what to search for. Let's take a call when any of these links break.

@jdroenner jdroenner merged commit 29a9585 into georust:master Feb 4, 2021
@michaelkirk
Copy link
Member

Excellent - Thank you @rmanoka!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants