Fix use-after-free in Dataset::close

georust · Jul 5, 2023 · 8bea21e · 8bea21e
1 parent 26236ba
commit 8bea21e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,6 +1,10 @@
 # Changes
 
 ## Unreleased
+- `Dataset::close` now consumes `self`
+
+ - <https://github.com/georust/gdal/pull/420>
+
 - Fixed build error with GDAL 3.1
 
  - <https://github.com/georust/gdal/pull/416>

diff --git a/src/dataset.rs b/src/dataset.rs
@@ -429,7 +429,7 @@ impl Dataset {
     /// See [`GDALClose`].
     ///
     /// Note: on GDAL versions older than 3.7, this function always succeeds.
-    pub fn close(&mut self) -> Result<()> {
+    pub fn close(self) -> Result<()> {
         #[cfg(any(all(major_ge_3, minor_ge_7), major_ge_4))]
         {
             let rv = unsafe { gdal_sys::GDALClose(self.c_dataset) };