Merge #329

329: Drop `trybuild` test r=jdroenner a=lnicola

- [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md).
- [ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.
---

Follow-up to #236
Closes #312

`trybuild` sounds nice, however:

 - it doesn't work (out of the box) with multiple compiler versions, so it breaks when upgrading compilers: #234
 - when testing with `--all-features`, it causes the code to be rebuilt twice
 - I've seen it give some weird errors in unusual circumstances (under `gdb`, maybe?)
 - it's completely broken for `@metasim` (#312), but not on CI, see also #312 (comment)
 - 1.5 years later, we still only have one test

Co-authored-by: Laurențiu Nicola <[email protected]>

Cargo.toml

@@ -31,7 +31,6 @@ semver = "1.0"
 
 [dev-dependencies]
 tempfile = "3.3"
-trybuild = "1.0"
 
 [workspace]
 members = ["gdal-sys"]

src/vector/vector_tests/mod.rs

@@ -804,25 +804,6 @@ mod tests {
         });
     }
 
-    #[test]
-    fn test_features_aliasing_compile_fail() {
-        let t = trybuild::TestCases::new(); // A compilation test that should fail.
-        t.compile_fail("tests/compile-tests/01-features-aliasing-errors.rs");
-    }
-
-    // It tries to iterate over a layer's features, while
-    // also trying to read the layer's definition. The
-    // features iterator borrows layer as a mutable ref as
-    // it increments the internal state of the layer.
-    //
-    // fn test_features_mut_lifetime_enforce() {
-    //     with_layer("roads.geojson", |mut layer| {
-    //         for _ in layer.features() {
-    //             let _ = layer.defn();
-    //         }
-    //     });
-    // }
-
     #[test]
     fn test_set_attribute_filter() {
         with_layer("roads.geojson", |mut layer| {