Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

Update the user guide #199

Merged
merged 5 commits into from
Feb 27, 2020
Merged

Update the user guide #199

merged 5 commits into from
Feb 27, 2020

Conversation

jzhang-gp
Copy link
Contributor

Description

Update the user doc.

@jzhang-gp jzhang-gp requested a review from jichaoz January 9, 2020 20:12
Copy link
Contributor

@jichaoz jichaoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please take a look at my inline comments.


# Create the foreshadow object
shadow = fs.Foreshadow(X_preparer=x_processor, y_preparer=y_processor, estimator=XGBRegressor())
Foreshadow uses a machine learning model to power the auto intent resolving step. As a user, you may not agree with the decision made by Foreshadow. The following APIs allow you to inspect the decisions and change them if you have a different opinion.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add a section to briefly introduce the major functionality of Foreshadow at the beginning and point that one of the features is automatic intent resolving (we might need to explain what we mean by intent as well). With that foundation established, it will be easier to just say the decisions can be changed by users here.

Copy link

@Akshayab Akshayab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks great. Added a few comments.

doc/users.rst Outdated

First import foreshadow
In this tutorial, we will go through a typical ML workflow with Foreshadow using a subset of the `adult data set <https://archive.ics.uci.edu/ml/datasets/Adult>`_ from the UCI machine learning repository.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor quibble: Wonder if more common datasets out there (like Boston or IRIS used by most tutorials) that people might be more familiar with are a better fit here. Sklearn datasets are probably a good place to dig.

Shouldn't be blocking though - adult dataset is a good representation of what you might see in real life.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually spotted a bug using the Iris data set with intent override. The fix is already published to a PR. Thanks for pointing this out!

doc/users.rst Outdated Show resolved Hide resolved
doc/users.rst Outdated Show resolved Hide resolved
doc/users.rst Show resolved Hide resolved
@jzhang-gp jzhang-gp merged commit 2dcfb17 into development Feb 27, 2020
@jzhang-gp jzhang-gp deleted the update_docs branch March 5, 2020 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants