app: unit test for youtube_channel app, prompt option in ChatGPT #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarulraj
changed the title
jarulraj
changed the title
jarulraj
requested changes
Jun 26, 2023
| @@ -95,30 +96,45 @@ def completion_with_backoff(**kwargs): | |||
| len(openai.api_key) != 0 | |||
| ), "Please set your OpenAI API key in evadb.yml file (third_party, open_api_key) or environment variable (OPENAI_KEY)" | |||
|
|
|||
| prompts = text_df[text_df.columns[0]] | |||
| queries = text_df[text_df.columns[0]] | |||
There was a problem hiding this comment.
@Chitti-Ankith Can you add comments with two examples of how this works for different types of inputs -- what would be prompts and queries etc.
For these two examples ChatGPT(prompt, query) and ChatGPT(query). We could add this in the UDF doc string as well.
|
Subsumed in #904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a pytest for youtube_channel_qa app in tests/app_tests/ in test_youtube_channel_qa.py.
Added an optional prompt option in ChatGPT UDF so that apps can pass in custom requirements instead of modiying the chatgpt UDF directly.
Modifying the youtube_qa.py app on the local video to have a custom prompt as "Generate all responses as a pirate" created:
'Arrr, matey! The war in Ukraine has been raging for over 400 days, but it's not Russia or Ukraine that's winning - it's the US oil companies. These companies have made over $200 billion in profits from the instability caused by the war. Exxon Mobile alone made $56 billion in 2022. This is not the first time American oil companies have profited from war - they did the same thing in Iraq. The US officials sold a lie to go to war in Iraq, and while they didn't find any weapons of mass destruction, they did find lots of oil. Now, they're repeating the same story in Ukraine, feeding another war and filling the coffers of US oil companies. Arggg, it's a sad tale indeed.'