fix: Renaming Cursor Functions #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aryan-rajoria
commented
Jun 25, 2023
•
aryan-rajoria
commented
- Renaming Cursor Functions to better understand their uses.
- Fixing create_vector_index() docstring
This PR removes CREATE MATERIALIZED VIEW statement, a deprecated feature. --------- Co-authored-by: xzdandy <[email protected]> Co-authored-by: jarulraj <[email protected]>
|
@aryan-rajoria Please update the docs as well, that's very important. |
👋 Thanks for submitting a Pull Request to EvaDB! 🙌 We want to make contributing to EvaDB as easy and transparent as possible. Here are a few tips to get you started: - 🔍 Search existing EvaDB [PRs](https://github.com/georgia-tech-db/eva/pulls) to see if a similar PR already exists. - 🔗 Link this PR to a EvaDB [issue](https://github.com/georgia-tech-db/eva/issues) to help us understand what bug fix or feature is being implemented. - 📈 Provide before and after profiling results to help us quantify the improvement your PR provides (if applicable). 👉 Please see our ✅ [Contributing Guide](https://evadb.readthedocs.io/en/stable/source/contribute/index.html) for more details. --------- Co-authored-by: Chitti Ankith <[email protected]>
This PR presents a sample app that lets users run data analytics with pandas like a conversation, credits to workflows presented by [pandas-ai](https://github.com/gventuri/pandas-ai) Example: 🔮 Welcome to EvaDB! This app lets you to run data analytics on a csv file like in a conversational manner. You will only need to supply a path to csv file and an OpenAI API key. 📋 Enter the csv file path (press Enter to use our default csv file): [enter] 🔑 Enter your OpenAI key: [your openai key] Could not find image processor class in the image processor config or the model config. Loading based on pattern matching with the model's feature extractor configuration. \=========================================== 🪄 Run anything on the csv table like a conversation! What do you want to do with the dataframe? (enter 'exit' to exit): print out the 3 countries with the highest GDPs ⏳ Generating response (may take a while)... \+--------------------------------------------------+ ✅ Script body: \# First, we need to sort the dataframe by GDP in descending order sorted_df = df.sort_values(by='gdp', ascending=False) \# Then, we can select the top 3 countries with the highest GDPs top_3_countries = sorted_df.head(3)['country'] \# Finally, we can print out the result print("The 3 countries with the highest GDPs are:") for country in top_3_countries: print(country) \+--------------------------------------------------+ 🪄 Want to run it? (y/n): y The 3 countries with the highest GDPs are: United States China Japan ✅ Session ended. \=========================================== --------- Co-authored-by: Yulai Cui <[email protected]> Co-authored-by: Gaurav <[email protected]> Co-authored-by: Yulai Cui <[email protected]> Co-authored-by: jarulraj <[email protected]>
👋 Thanks for submitting a Pull Request to EvaDB! 🙌 We want to make contributing to EvaDB as easy and transparent as possible. Here are a few tips to get you started: - 🔍 Search existing EvaDB [PRs](https://github.com/georgia-tech-db/eva/pulls) to see if a similar PR already exists. - 🔗 Link this PR to a EvaDB [issue](https://github.com/georgia-tech-db/eva/issues) to help us understand what bug fix or feature is being implemented. - 📈 Provide before and after profiling results to help us quantify the improvement your PR provides (if applicable). 👉 Please see our ✅ [Contributing Guide](https://evadb.readthedocs.io/en/stable/source/contribute/index.html) for more details. --------- Co-authored-by: xzdandy <[email protected]>
This PR addresses two issues. 1. We previously only allows parallelism when there is more than two GPUs available. I think this is too conservative. First, some functional expressions only run on CPUs and even parallelization of CPU functional expression can bring performance benefit. Additionally, even if there is only one GPU available, it still provide performance benefit when parallelization is enabled because of better GPU utilizations. Currently, I just hardcode the DOP, but I am thinking to allow users to configure this themselves through the `eva.yml`. Any feedback on this? @xzdandy @gaurav274 @jarulraj 2. I realize a bug related to the previous approach. This will happen for more than 1 GPU case. I will give a concrete example here. Let's assume we have two GPUs. The GPU id that we get from the `Context` for the second GPU is `1` because context runs in the main process, which detects two GPUs on the PyTorch side (e.g., `GPU ID = [0, 1]`. However, within the Ray process, after we set the environmental variable `CUDA_VISIBLE_DEVICES=1`, the PyTorch indices is reset. Because it only accesses one GPU within the Ray process, it only gets GPU ids like `GPU ID = [0]`. Thus, it causes the no GPU error when it moves to GPU `to('cuda:1')`. The fix is very easy, that we just simply expose all GPUs to every Ray process, so we don't need to worry about PyTorch device id reset. To expose all GPUs, we just find the max GPU id from the context and expose all GPU ids that are lower than the max in the environmental variables. --------- Co-authored-by: xzdandy <[email protected]>
* Validate index scan with descending order works fine * Add more error msg --------- Co-authored-by: jarulraj <[email protected]>
👋 Thanks for submitting a Pull Request to EvaDB! 🙌 We want to make contributing to EvaDB as easy and transparent as possible. Here are a few tips to get you started: - 🔍 Search existing EvaDB [PRs](https://github.com/georgia-tech-db/eva/pulls) to see if a similar PR already exists. - 🔗 Link this PR to a EvaDB [issue](https://github.com/georgia-tech-db/eva/issues) to help us understand what bug fix or feature is being implemented. - 📈 Provide before and after profiling results to help us quantify the improvement your PR provides (if applicable). 👉 Please see our ✅ [Contributing Guide](https://evadb.readthedocs.io/en/stable/source/contribute/index.html) for more details.
👋 Thanks for submitting a Pull Request to EvaDB! 🙌 We want to make contributing to EvaDB as easy and transparent as possible. Here are a few tips to get you started: - 🔍 Search existing EvaDB [PRs](https://github.com/georgia-tech-db/eva/pulls) to see if a similar PR already exists. - 🔗 Link this PR to a EvaDB [issue](https://github.com/georgia-tech-db/eva/issues) to help us understand what bug fix or feature is being implemented. - 📈 Provide before and after profiling results to help us quantify the improvement your PR provides (if applicable). 👉 Please see our ✅ [Contributing Guide](https://evadb.readthedocs.io/en/stable/source/contribute/index.html) for more details.
|
@aryan-rajoria We need to update the notebooks as well. |
jarulraj
added
Feature Request ✨
👋 Thanks for submitting a Pull Request to EvaDB! 🙌 We want to make contributing to EvaDB as easy and transparent as possible. Here are a few tips to get you started: - 🔍 Search existing EvaDB [PRs](https://github.com/georgia-tech-db/eva/pulls) to see if a similar PR already exists. - 🔗 Link this PR to a EvaDB [issue](https://github.com/georgia-tech-db/eva/issues) to help us understand what bug fix or feature is being implemented. - 📈 Provide before and after profiling results to help us quantify the improvement your PR provides (if applicable). 👉 Please see our ✅ [Contributing Guide](https://evadb.readthedocs.io/en/stable/source/contribute/index.html) for more details. --------- Co-authored-by: Chitti Ankith <[email protected]>
👋 Thanks for submitting a Pull Request to EvaDB! 🙌 We want to make contributing to EvaDB as easy and transparent as possible. Here are a few tips to get you started: - 🔍 Search existing EvaDB [PRs](https://github.com/georgia-tech-db/eva/pulls) to see if a similar PR already exists. - 🔗 Link this PR to a EvaDB [issue](https://github.com/georgia-tech-db/eva/issues) to help us understand what bug fix or feature is being implemented. - 📈 Provide before and after profiling results to help us quantify the improvement your PR provides (if applicable). 👉 Please see our ✅ [Contributing Guide](https://evadb.readthedocs.io/en/stable/source/contribute/index.html) for more details. --------- Co-authored-by: Chitti Ankith <[email protected]>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.