Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: similarity test #720

Merged
merged 5 commits into from
May 14, 2023
Merged

fix: similarity test #720

merged 5 commits into from
May 14, 2023

Conversation

jiashenC
Copy link
Member

  • Foreign key is not correctly configured, which prevents dataset tables to be dropped.
  • Storage read gets extra argument after storage engine change.
  • Add test case just to make sure index creation and similarity search runs correctly.

@jiashenC jiashenC requested a review from gaurav274 May 11, 2023 21:41
@jiashenC jiashenC mentioned this pull request May 12, 2023
Merged
@jiashenC jiashenC merged commit fb76bea into master May 14, 2023
@jiashenC jiashenC deleted the fix-similarity-test branch May 14, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzdandy xzdandy xzdandy approved these changes

@gaurav274 gaurav274 Awaiting requested review from gaurav274

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiashenC @xzdandy