Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: object tracking #566

Merged
merged 244 commits into from
May 15, 2023
Merged

feat: object tracking #566

merged 244 commits into from
May 15, 2023

Conversation

gaurav274
Copy link
Member

@gaurav274 gaurav274 commented Jan 20, 2023

Supported query:

SELECT id, T.iids, T.bboxes, T.scores, T.labels
FROM MyVideo JOIN LATERAL EXTRACT_OBJECT(data, YoloV5, NorFairTracker)
    AS T(iids, labels, bboxes, scores)
WHERE id < 30;

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@xzdandy xzdandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaurav274 Please help checking the Notebook test case.

@gaurav274
Copy link
Member Author

@gaurav274 Please help checking the Notebook test case.

Sure, looking into it.

@gaurav274
Copy link
Member Author

@xzdandy Hopefully, the changes should fix the build-related issue.
Btw, do you think there is a meaningful test case for object tracking? Also, please review that I accidentally didn't remove your changes.

@xzdandy
Copy link
Collaborator

xzdandy commented May 14, 2023

@xzdandy Hopefully, the changes should fix the build-related issue. Btw, do you think there is a meaningful test case for object tracking? Also, please review that I accidentally didn't remove your changes.

That is a good point. We should have a test case for EVAtracker abstract class and builtin nor_fair tracker.

@gaurav274
Copy link
Member Author

gaurav274 commented May 14, 2023

@xzdandy, why have notebooks changed? Feel free to merge it if you feel it is good to go.

@xzdandy
Copy link
Collaborator

xzdandy commented May 14, 2023

@xzdandy, why have notebooks changed? Feel free to merge it if you feel it is good to go.

I think running bash script/test/test.sh locally changes the notebook.

@gaurav274 gaurav274 merged commit b4fa64e into master May 15, 2023
@gaurav274 gaurav274 deleted the obj-tracking branch May 15, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

8 participants