-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support open command #514
Conversation
How will we use it in a query? |
@gaurav274 I think it can be just embedded in any statement that needs to get a numpy array from the source image (as we discussed here #478).
|
Yes, how will the query execution plan look like for this example? Since open is an operator and similarity will be part of an expression. We might have to implement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My assumption is that '../path/to/img.jpg'
locates on the client side (i.e., not server, otherwise we will use the load command to load the image?)
Than this logic should be at the client library where, for example, we turn this image into a base64 encoded string and the expression at the server side decodes it.
We assume it is on the server side and the user does not want to use an existing file. In theory, we can replace |
Decide to implement open as functional expression after discussion. |
Currently support open jpeg image and return a numpy array for it.