New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stable diffusion integration #1240

Merged

xzdandy merged 18 commits into georgia-tech-db:staging from sudoboi:diff

Oct 15, 2023

Collaborator

xzdandy commented Sep 30, 2023

Reopen the #1111.

sudoboi and others added 10 commits

September 13, 2023 10:41


          add stable diffusion integration

56e30a1


          Add dalle and fix bugs with stablediff

48cac63


          Add stable diffusion tutorial notebook

3dd7e19


          Add test for sd and other minor fixes

d64fff3


          Merge branch 'staging' into diff

c68f0da


          MINOR: linter fixes

033c266


          Merge branch 'diff' of https://github.com/sudoboi/evadb into diff

45e3e04


          Add tests for dalle and sd with mocking

c637a2d


          Formatting issues

68f0d23


          Tutorial notebok colab link add

d2c346f

xzdandy added the AI Engines label

xzdandy added this to the v0.3.7 milestone

xzdandy assigned sudoboi

review-notebook-app bot commented Sep 30, 2023

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Collaborator Author

xzdandy commented Sep 30, 2023

Quick notice:

Fix testcases
Please change the notebook name and if notebook also does not work on circle ci, we can skip the it. You can do it in script/test/test.sh. Do let us know why it does not work.
Add a documentation to the function under https://evadb.readthedocs.io/en/stable/source/reference/ai/index.html
Both test/integration_tests/long/functions/test_dalle.py and test/integration_tests/long/functions/test_selfdiffusion.py look unit tests instead of long integration tests, which is fine. If so, move them to test/unit_tests.

xzdandy commented

View reviewed changes

evadb/functions/function_bootstrap_queries.py Outdated Show resolved Hide resolved

xzdandy commented

View reviewed changes

evadb/functions/stable_diffusion.py Outdated Show resolved Hide resolved

xzdandy commented

View reviewed changes

evadb/functions/stable_diffusion.py Outdated Show resolved Hide resolved

xzdandy commented

View reviewed changes

evadb/functions/stable_diffusion.py Outdated Show resolved Hide resolved

xzdandy commented

View reviewed changes

test/integration_tests/long/functions/test_dalle.py Outdated Show resolved Hide resolved

xzdandy commented

View reviewed changes

test/integration_tests/long/functions/test_selfdiffusion.py Outdated Show resolved Hide resolved

xzdandy commented

View reviewed changes

test/integration_tests/long/functions/test_selfdiffusion.py Outdated Show resolved Hide resolved

xzdandy modified the milestones: v0.3.7, v0.3.8

sudoboi and others added 4 commits

October 11, 2023 13:37


          Merge branch 'georgia-tech-db:staging' into diff

f7977b0


          stable diffusion revamp and new tests

9aa71b9


          Removing old tests and notebook.

79e8566


          Doc and linter fixes.

0b81afd

sudoboi requested a review from aryan-rajoria

October 12, 2023 03:47

Collaborator Author

xzdandy commented Oct 12, 2023 •

edited

Loading

Hi @sudoboi, I do not have permission to push to your fork since I am not the reviewer. We need to change the script/test/test.sh to skip the tutorials/18-stable-diffusion.ipynb due to the replicate API key. Overall looks great! Thanks!


          Modify test.sh to ignore sd tutorial notebook

d842dce

aryan-rajoria reviewed

View reviewed changes

evadb/functions/stable_diffusion.py Outdated Show resolved Hide resolved

test/integration_tests/long/functions/test_stablediffusion.py Show resolved Hide resolved

sudoboi added 3 commits

October 12, 2023 13:24


          Remove the markers to test if working on circleci

6edc83c


          Take API key from config manager

2847f9f


          Linter fixes

51392c1

xzdandy requested review from jiashenC and gaurav274

October 15, 2023 07:13

Collaborator Author

xzdandy commented Oct 15, 2023

Hi @gaurav274 and @jiashenC, please help review the PR. The PR looks good to me. But I reopened the PR, so I can not approve.

jiashenC approved these changes

View reviewed changes

xzdandy merged commit bf02232 into georgia-tech-db:staging

RichardZhangRZ pushed a commit to RichardZhangRZ/evadb that referenced this pull request


          Add stable diffusion integration (georgia-tech-db#1240)

83d1176

Reopen the georgia-tech-db#1111.

---------

Co-authored-by: sudoboi <[email protected]>
Co-authored-by: Abhijith S Raj <[email protected]>

a0x8o pushed a commit to alexxx-db/eva that referenced this pull request


          Add stable diffusion integration (georgia-tech-db#1240)

2b924b7

Reopen the georgia-tech-db#1111.

---------

Co-authored-by: sudoboi <[email protected]>
Co-authored-by: Abhijith S Raj <[email protected]>

a0x8o pushed a commit to alexxx-db/eva that referenced this pull request


          Add stable diffusion integration (georgia-tech-db#1240)

8a8a90a

Reopen the georgia-tech-db#1111.

---------

Co-authored-by: sudoboi <[email protected]>
Co-authored-by: Abhijith S Raj <[email protected]>

a0x8o pushed a commit to alexxx-db/eva that referenced this pull request


          Add stable diffusion integration (georgia-tech-db#1240)

f9b931f

Reopen the georgia-tech-db#1111.

---------

Co-authored-by: sudoboi <[email protected]>
Co-authored-by: Abhijith S Raj <[email protected]>

a0x8o pushed a commit to alexxx-db/eva that referenced this pull request


          Add stable diffusion integration (georgia-tech-db#1240)

a561022

Reopen the georgia-tech-db#1111.

---------

Co-authored-by: sudoboi <[email protected]>
Co-authored-by: Abhijith S Raj <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels